1416034 - Refuse to run client.mk without mach

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

We've reached the point of moving things out of client.mk where we'll need to enforce that mach is used alongside client.mk before we can move the remaining logic.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1416034 - Refuse to run client.mk unless using mach;

We will soon begin the process of moving logic from client.mk
into mach. Once we start this process, it won't be possible to
invoke client.mk in isolation.

This commit introduces a check in client.mk that will error unless
client.mk is executed from mach. This should help more easily
identify users of client.mk during the transition period - before
client.mk is removed and callers start getting missing file errors.

Obviously the check can be bypassed easily. If someone does this,
upcoming changes will quickly break that workflow. So this isn't a
big deal.

Review commit: https://reviewboard.mozilla.org/r/198280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198280/

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8927061 [details]
Bug 1416034 - Refuse to run client.mk unless using mach;

https://reviewboard.mozilla.org/r/198280/#review203534

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79f2b6f0c44c
Refuse to run client.mk unless using mach; r=ted

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/79f2b6f0c44c