Closed Bug 1416059 Opened 2 years ago Closed 2 years ago

Move ASFLAGS to mozbuild computed flags

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

These are pretty straightforward and can use the machinery from bug 1362612
Blocks: 1416062
Assignee: nobody → cmanchester
Comment on attachment 8928002 [details]
Bug 1416059 - Emit ASFLAGS and YASM_ASFLAGS from configure as lists.

https://reviewboard.mozilla.org/r/199242/#review204496
Attachment #8928002 - Flags: review?(mshal) → review+
Comment on attachment 8928003 [details]
Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

https://reviewboard.mozilla.org/r/199244/#review204498
Attachment #8928003 - Flags: review?(mshal) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0df69766fa5
Emit ASFLAGS and YASM_ASFLAGS from configure as lists. r=mshal
https://hg.mozilla.org/integration/autoland/rev/597624409f4c
Move ASFLAGS logic from config.mk to mozbuild. r=mshal
Backed out for for failing /python/mozbuild/mozbuild/test/frontend/test_emitter.py::TestEmitterBasic::test_use_yasm r=backout on a CLOSED TREE

Error log: https://treeherder.mozilla.org/logviewer.html#?job_id=144657494&repo=autoland&lineNumber=30007

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=597624409f4c58cbd25376e1a3f4398c63b45c74

Backout: https://hg.mozilla.org/integration/autoland/rev/e2e96cb6d4807899cb918ba69227d3ae1e141ac2
Flags: needinfo?(cmanchester)
Silly `hg add` issue... will re-land shortly.
Flags: needinfo?(cmanchester)
Attachment #8928236 - Attachment is obsolete: true
Comment on attachment 8928003 [details]
Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

https://reviewboard.mozilla.org/r/199244/#review204564
Attachment #8928003 - Flags: review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edadec9ac205
Emit ASFLAGS and YASM_ASFLAGS from configure as lists. r=mshal
https://hg.mozilla.org/integration/autoland/rev/b90598123a58
Move ASFLAGS logic from config.mk to mozbuild. r=mshal
https://hg.mozilla.org/mozilla-central/rev/edadec9ac205
https://hg.mozilla.org/mozilla-central/rev/b90598123a58
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.