1416059 - Move ASFLAGS to mozbuild computed flags

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

These are pretty straightforward and can use the machinery from bug 1362612

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1416059 - Emit ASFLAGS and YASM_ASFLAGS from configure as lists.

Review commit: https://reviewboard.mozilla.org/r/199242/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199242/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

Review commit: https://reviewboard.mozilla.org/r/199244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199244/

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8928002 [details]
Bug 1416059 - Emit ASFLAGS and YASM_ASFLAGS from configure as lists.

https://reviewboard.mozilla.org/r/199242/#review204496

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8928003 [details]
Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

https://reviewboard.mozilla.org/r/199244/#review204498

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0df69766fa5
Emit ASFLAGS and YASM_ASFLAGS from configure as lists. r=mshal
https://hg.mozilla.org/integration/autoland/rev/597624409f4c
Move ASFLAGS logic from config.mk to mozbuild. r=mshal

Comment 6

[Andreea Pavel [:apavel]]

Backed out for for failing /python/mozbuild/mozbuild/test/frontend/test_emitter.py::TestEmitterBasic::test_use_yasm r=backout on a CLOSED TREE

Error log: https://treeherder.mozilla.org/logviewer.html#?job_id=144657494&repo=autoland&lineNumber=30007

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=597624409f4c58cbd25376e1a3f4398c63b45c74

Backout: https://hg.mozilla.org/integration/autoland/rev/e2e96cb6d4807899cb918ba69227d3ae1e141ac2

Comment 7

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1416059 - Fix up: hg add missing test file

Review commit: https://reviewboard.mozilla.org/r/199456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199456/

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8928002 [details]
Bug 1416059 - Emit ASFLAGS and YASM_ASFLAGS from configure as lists.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199242/diff/1-2/

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8928003 [details]
Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199244/diff/1-2/

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Silly `hg add` issue... will re-land shortly.

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8928003 [details]
Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199244/diff/2-3/

Comment 12

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8928003 [details]
Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild.

https://reviewboard.mozilla.org/r/199244/#review204564

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edadec9ac205
Emit ASFLAGS and YASM_ASFLAGS from configure as lists. r=mshal
https://hg.mozilla.org/integration/autoland/rev/b90598123a58
Move ASFLAGS logic from config.mk to mozbuild. r=mshal

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/edadec9ac205
https://hg.mozilla.org/mozilla-central/rev/b90598123a58