Closed
Bug 1416059
Opened 6 years ago
Closed 6 years ago
Move ASFLAGS to mozbuild computed flags
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(2 files, 1 obsolete file)
These are pretty straightforward and can use the machinery from bug 1362612
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → cmanchester
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8928002 [details] Bug 1416059 - Emit ASFLAGS and YASM_ASFLAGS from configure as lists. https://reviewboard.mozilla.org/r/199242/#review204496
Attachment #8928002 -
Flags: review?(mshal) → review+
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8928003 [details] Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild. https://reviewboard.mozilla.org/r/199244/#review204498
Attachment #8928003 -
Flags: review?(mshal) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d0df69766fa5 Emit ASFLAGS and YASM_ASFLAGS from configure as lists. r=mshal https://hg.mozilla.org/integration/autoland/rev/597624409f4c Move ASFLAGS logic from config.mk to mozbuild. r=mshal
Comment 6•6 years ago
|
||
Backed out for for failing /python/mozbuild/mozbuild/test/frontend/test_emitter.py::TestEmitterBasic::test_use_yasm r=backout on a CLOSED TREE Error log: https://treeherder.mozilla.org/logviewer.html#?job_id=144657494&repo=autoland&lineNumber=30007 Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=597624409f4c58cbd25376e1a3f4398c63b45c74 Backout: https://hg.mozilla.org/integration/autoland/rev/e2e96cb6d4807899cb918ba69227d3ae1e141ac2
Flags: needinfo?(cmanchester)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•6 years ago
|
||
Silly `hg add` issue... will re-land shortly.
Flags: needinfo?(cmanchester)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8928236 -
Attachment is obsolete: true
Assignee | ||
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8928003 [details] Bug 1416059 - Move ASFLAGS logic from config.mk to mozbuild. https://reviewboard.mozilla.org/r/199244/#review204564
Attachment #8928003 -
Flags: review+
Comment 13•6 years ago
|
||
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edadec9ac205 Emit ASFLAGS and YASM_ASFLAGS from configure as lists. r=mshal https://hg.mozilla.org/integration/autoland/rev/b90598123a58 Move ASFLAGS logic from config.mk to mozbuild. r=mshal
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/edadec9ac205 https://hg.mozilla.org/mozilla-central/rev/b90598123a58
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•