1416076 - 19% of WebRenderLayerManager::EndTransaction during MotionMark is in nsDisplayItem::RecomputeVisibilty

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

It seems like we could do something much simpler when we're using blob images.

Comment 1

[Ethan Lin[:ethlin]]

Indeed, the RecomputeVisibilty has some region computations. For webrender, we should just call ComputeVisibility.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Bug 1416076 - We should set visible rect to display item before computing visibility.

Review commit: https://reviewboard.mozilla.org/r/198566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198566/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Please don't regress bug 1403920. I had changed this to RecomputeVisibility specifically to avoid that problem.

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)
> Please don't regress bug 1403920. I had changed this to RecomputeVisibility
> specifically to avoid that problem.

Oh..I should think another way.

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8927257 [details]
Bug 1416076 - We should set visible rect to display item before computing visibility.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198566/diff/1-2/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8927257 [details]
Bug 1416076 - We should set visible rect to display item before computing visibility.

https://reviewboard.mozilla.org/r/198566/#review204330

Matt is probably a better reviewer for this visibility stuff.

::: commit-message-f944b:1
(Diff revision 2)
> +Bug 1416076 - We should set visibile rect to display item before computing visibility. r=kats

s/visibile/visible/

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8927257 [details]
Bug 1416076 - We should set visible rect to display item before computing visibility.

https://reviewboard.mozilla.org/r/198566/#review204626

Comment 8

[Ethan Lin[:ethlin]]

Comment on attachment 8927257 [details]
Bug 1416076 - We should set visible rect to display item before computing visibility.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198566/diff/2-3/

Comment 9

[Ethan Lin[:ethlin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05a626c515e50c0487b7013d05d3b94285fab7b7

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b468a6f584f8
We should set visible rect to display item before computing visibility. r=mattwoodrow

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b468a6f584f8