Closed Bug 1416142 Opened 3 years ago Closed 3 years ago

Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_omnibox.js | Test timed out -

Categories

(WebExtensions :: General, defect, P2)

defect

Tracking

(firefox58 fixed, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mak)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fxsearch][stockwell unknown])

Attachments

(1 file)

See Also: → 1415908
Since 10th November there are 34 failures.
:andym could you please take a look?
Flags: needinfo?(amckay)
Whiteboard: [stockwell needswork:owner]
If the other fix in bug 1415908 sticks, I can have a look at this as well, maybe I'll figure out something.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #8931446 - Flags: review?(adw) → review?(standard8)
Comment on attachment 8931446 [details]
Bug 1416142 - Intermittent timeout in browser_ext_omnibox.js.

https://reviewboard.mozilla.org/r/202600/#review208454

Not quite sure I see the reason why we'd need to click muliple times unless we're not waiting for visible/enabled or something. However, this seems like a good thing to try, and having the listeners set up before the event could help a bit as well.
Attachment #8931446 - Flags: review?(standard8) → review+
I will add a comment, the reason is that the panel animates, and by the time we click the animation may still be ongoing and the events are not yet being listened for.
Flags: needinfo?(amckay)
Attachment #8931446 - Flags: review?(adw)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/21c5a7b20041
Intermittent timeout in browser_ext_omnibox.js. r=standard8
Priority: -- → P2
Whiteboard: [stockwell needswork:owner] → [stockwell needswork:owner][fxsearch]
https://hg.mozilla.org/mozilla-central/rev/21c5a7b20041
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.