Closed Bug 1416155 Opened 7 years ago Closed 3 months ago

Get rid of JS_ParseJSONWithReviver

Categories

(Core :: JavaScript Engine, enhancement, P5)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox58 --- wontfix
firefox59 --- ?

People

(Reporter: baku, Unassigned)

References

Details

Attachments

(1 file)

json5.patch
4.19 KB, patch
Details | Diff | Splinter Review 
This function is not needed anymore because of bug 1347515
Attached patch json5.patch — — Splinter Review 

  

  


Assignee: nobody → amarchesini

        Attachment #8927245 -
        Flags: review?(evilpies)

    
  
Depends on: 1347515

    
    

    
  
I don't think we need to remove this. I was probably thinking about this https://searchfox.org/mozilla-central/rev/30ead7d1ae5bf95b8bc0fd67b950cd46ca05e32c/js/src/json.cpp#967 when I mentioned we could simplify something. I also thought we had special error handling for the old JSON code, but apparently that is just for eval. Maybe somebody else knows something we could simplify now that nsJSON was removed.

  

  



    
  

        Attachment #8927245 -
        Flags: review?(evilpies)

          status-firefox58:
          --- → fix-optional
Priority: -- → P5

    
    

    
  
Better if JS folks work on this bug.

  

  


Assignee: amarchesini → nobody

    
  
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: