1416174 - Crash in mozilla::dom::WorkerGlobalScope::GetExistingNavigator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ciprian Georgiu, Desktop QA]

This bug was filed from the Socorro interface and is
report bp-bd5142e5-4c2f-4e79-9af2-fa4590171109.
=============================================================

[Affected versions]:
- latest Nightly 58.0a1 (2017-11-09)
- 57.0 RC (20171109183137)
- 56.0.2 (20171024165158)
- 52.5.0 esr (20171107091003)

[Affected platforms]:
- Windows 10 x64
- macOS 10.13
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Start Firefox.
2. Run the following code in the browser console:

  try { Cc["@mozilla.org/net/osfileconstantsservice;1"].createInstance(Ci.nsIXMLHttpRequest);}catch(err){}
  try { Cc["@mozilla.org/places/colorAnalyzer;1"].createInstance(Ci.nsIXMLHttpRequest);}catch(err){}

3. Close Firefox via hamburger menu.

[Expected result]:
- There's no crash after closing Firefox.

[Actual result]:
- Firefox crashes.

[Regression range]:
- I don't think this is a regression, I was able to reproduce this on FF 32.0 as well.

[Additional notes]:
- see this screencast: https://imgur.com/a/w4yq6 in order to reproduce the issue

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - OSFileConstants must be a singleton

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 2 - OSFileConstants as nsIObserver

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 3 - moving gPaths to mPaths

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8927314 [details] [diff] [review]
part 3 - moving gPaths to mPaths

Folks tend to prefer UniquePtr over nsAutoPtr.
That fixed, r+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc82839201a6
part 1 - OSFileConstants must be a singleton, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b1d10a8644b
part 2 - OSFileConstants as nsIObserver, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9246983376b
part 3 - moving gPaths to mPaths,r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/05603dbb4dd8
part 4 - OSFileConstants should use UniquePtr instead of nsAutoPtr, r=smaug

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dc82839201a6
https://hg.mozilla.org/mozilla-central/rev/9b1d10a8644b
https://hg.mozilla.org/mozilla-central/rev/a9246983376b
https://hg.mozilla.org/mozilla-central/rev/05603dbb4dd8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Volume on ESR52 is low enough that I don't think we care.