Windows coverage builds hitting crash in LateWriteChecks during tests

RESOLVED FIXED in Firefox 59

Status

Testing
Code Coverage
RESOLVED FIXED
9 days ago
6 days ago

People

(Reporter: marco, Assigned: marco)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

9 days ago
Created attachment 8927342 [details]
log.tar.xz

Hit MOZ_CRASH() at z:/build/build/src/xpcom/build/LateWriteChecks.cpp:116
(Assignee)

Comment 1

7 days ago
Created attachment 8927810 [details] [diff] [review]
Patch

I suppose the failure is due to the fact that the instrumented build is writing the coverage counters on exit.
I'm not sure why there's no crash on Linux.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8927810 - Flags: review?(nfroyd)
Attachment #8927810 - Flags: review?(nfroyd) → review+

Comment 2

6 days ago
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15fa308daad3
Don't crash when there are late writes in the Windows coverage build. r=froydnj

Comment 3

6 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/15fa308daad3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.