Closed Bug 1416235 Opened 2 years ago Closed 2 years ago

Windows coverage builds hitting crash in LateWriteChecks during tests

Categories

(Testing :: Code Coverage, defect)

defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(2 files)

Attached file log.tar.xz
Hit MOZ_CRASH() at z:/build/build/src/xpcom/build/LateWriteChecks.cpp:116
Attached patch PatchSplinter Review
I suppose the failure is due to the fact that the instrumented build is writing the coverage counters on exit.
I'm not sure why there's no crash on Linux.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8927810 - Flags: review?(nfroyd)
Attachment #8927810 - Flags: review?(nfroyd) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15fa308daad3
Don't crash when there are late writes in the Windows coverage build. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/15fa308daad3
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
See Also: → 1465739
You need to log in before you can comment on or make changes to this bug.