Closed
Bug 1416246
Opened 8 years ago
Closed 8 years ago
Remove conditional catch consumers in accessible/.
Categories
(Core :: Disability Access APIs, enhancement)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
2.37 KB,
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
non-standard conditional catch syntax is going to be removed in bug 1228841.
there are 2 cases for replacement.
case 1: only conditional catch
from:
try {
A
} catch (e if cond) {
B
}
to
try {
A
} catch (e) {
if (!cond) {
throw e;
}
B
}
case 2: conditional catch and unconditional catch
from:
try {
A
} catch (e if cond) {
B
} catch {
C
}
to
try {
A
} catch (e) {
if (cond) {
B
} else {
C
}
}
| Assignee | ||
Updated•8 years ago
|
| Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8928548 -
Flags: review?(mzehe)
Comment 2•8 years ago
|
||
Comment on attachment 8928548 [details] [diff] [review]
Remove conditional catch consumers in accessible/.
Thanks!
Attachment #8928548 -
Flags: review?(mzehe) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee65b4ddd8d3
Remove conditional catch consumers in accessible/. r=MarcoZ
| Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee65b4ddd8d37d4009f19db080a092d5a0d9e936
Bug 1416246 - Remove conditional catch consumers in accessible/. r=MarcoZ
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•