Closed Bug 1416252 Opened 3 years ago Closed 3 years ago

Remove conditional catch consumers in modules/libjar/.

Categories

(Core :: Networking: JAR, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

non-standard conditional catch syntax is going to be removed in bug 1228841.

there are 2 cases for replacement.

case 1: only conditional catch

from:
  try {
    A
  } catch (e if cond) {
    B
  }
to
  try {
    A
  } catch (e) {
    if (!cond) {
      throw e;
    }
    B
  }

case 2: conditional catch and unconditional catch

from:
  try {
    A
  } catch (e if cond) {
    B
  } catch {
    C
  }
to
  try {
    A
  } catch (e) {
    if (cond) {
      B
    } else {
      C
    }
  }
Priority: -- → P5
Whiteboard: [necko-triaged]
Attachment #8928552 - Flags: review?(dtownsend) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d30660dbdebe
Remove conditional catch consumers in modules/libjar/. r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/d30660dbdebebf2f02304fe88de37e6cd0b12532
Bug 1416252 - Remove conditional catch consumers in modules/libjar/. r=mossop
https://hg.mozilla.org/mozilla-central/rev/d30660dbdebe
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.