Closed
Bug 1416252
Opened 9 years ago
Closed 8 years ago
Remove conditional catch consumers in modules/libjar/.
Categories
(Core :: Networking: JAR, enhancement, P5)
Core
Networking: JAR
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: arai, Assigned: arai)
References
Details
(Whiteboard: [necko-triaged])
Attachments
(1 file)
|
2.86 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
non-standard conditional catch syntax is going to be removed in bug 1228841.
there are 2 cases for replacement.
case 1: only conditional catch
from:
try {
A
} catch (e if cond) {
B
}
to
try {
A
} catch (e) {
if (!cond) {
throw e;
}
B
}
case 2: conditional catch and unconditional catch
from:
try {
A
} catch (e if cond) {
B
} catch {
C
}
to
try {
A
} catch (e) {
if (cond) {
B
} else {
C
}
}
Updated•9 years ago
|
Priority: -- → P5
Whiteboard: [necko-triaged]
| Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8928552 -
Flags: review?(dtownsend)
Updated•8 years ago
|
Attachment #8928552 -
Flags: review?(dtownsend) → review+
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d30660dbdebe
Remove conditional catch consumers in modules/libjar/. r=mossop
| Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d30660dbdebebf2f02304fe88de37e6cd0b12532
Bug 1416252 - Remove conditional catch consumers in modules/libjar/. r=mossop
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•