1416287 - ssl3exthandle.c Fix signed / unsigned compilation warnings

Status: RESOLVED WORKSFORME

(NSS :: Libraries, defect)

Description

[jbonnafo]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20171024165158

Steps to reproduce:

Using Visual Studio 2017 compiler, ssl3exthandle.c generates compilation warnings.


Actual results:

Generated warnings are:
security/nss/lib/ssl/ssl3exthandle.c:2080 [C4018] '<': signed/unsigned mismatch
security/nss/lib/ssl/ssl3exthandle.c:2132 [C4018] '<': signed/unsigned mismatch


Expected results:

Code should compile without any warning.

Comment 1

[jbonnafo]

Hello,

following a code rebase, it seems that ssl3exthandle.c does not use int32, i am going to check if there are still some warnings to be fixed.

Thanks,

Comment 2

[jbonnafo]

Hello,

i can confirm that with latest trunk code, ssl3exthandle.c compiles without any warning.
Should we close this bug?

Thanks,

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Sure, let's close it.