Closed Bug 1416377 Opened 7 years ago Closed 6 years ago

Use new async Places APIs in test_refresh_firefox.py

Categories

(Firefox :: Migration, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: MattN, Assigned: mak)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [fx-search])

Attachments

(1 file)

(Quoting to Marco Bonardo [::mak] from bug 1415692 comment #20)
> Comment on attachment 8926763 [details]
> Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks
> on it.
> 
> https://reviewboard.mozilla.org/r/198002/#review203696
> …
> ::: browser/components/migration/tests/marionette/test_refresh_firefox.py:58
> (Diff revision 3)
> >          """, script_args=(self._bookmarkURL, self._bookmarkText))
> >  
> > +    def createBookmarksOnToolbar(self):
> > +        self.marionette.execute_script("""
> > +          for (let i = 1; i <= 5; i++) {
> > +            PlacesUtils.bookmarks.insertBookmark(PlacesUtils.toolbarFolderId,
> 
> It would be great if this code would use the new async bookmarking API,
> rather than the old one, maybe in a follow-up?
> 
> ::: browser/components/migration/tests/marionette/test_refresh_firefox.py:67
> (Diff revision 3)
> > +
> >      def createHistory(self):
> >          error = self.runAsyncCode("""
> >            // Copied from PlacesTestUtils, which isn't available in Marionette tests.
> >            let didReturn;
> >            PlacesUtils.asyncHistory.updatePlaces(
> 
> As well as it would be great if it would use
> PlacesUtils.history.insertMany... (again, a follow-up bug would be fine)
Blocks: 1083465
Blocks: 1432439
we reached the point where we can start removing APIs, this prevents some removals.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Priority: P5 → P1
Whiteboard: [fx-search]
Comment on attachment 8944723 [details]
Bug 1416377 - Use new async Places APIs in test_refresh_firefox.py.

https://reviewboard.mozilla.org/r/214868/#review220972
Attachment #8944723 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/6cf7e7fda675
Use new async Places APIs in test_refresh_firefox.py. r=standard8
https://hg.mozilla.org/mozilla-central/rev/6cf7e7fda675
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: