Closed
Bug 1416524
Opened 7 years ago
Closed 7 years ago
Remove unused "button-image" binding
Categories
(Toolkit :: UI Widgets, task, P5)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: bgrins, Assigned: u605551)
References
Details
(Keywords: good-first-bug, Whiteboard: [xbl-remove-unused][xbl-available])
Attachments
(1 file)
|
877 bytes,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
There's a binding "button-image" that I can't find any usage of:
- https://dxr.mozilla.org/mozilla-central/rev/69e24c678a28dc46a4c1bda3ff04b2f6106ff71a/toolkit/content/widgets/button.xml#379-384
- https://dxr.mozilla.org/mozilla-central/search?q=%22button.xml%23button-image%22&redirect=true
I believe the code in button.xml can just be removed.
|
||
Updated•7 years ago
|
Keywords: good-first-bug
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → wontfix
status-firefox59:
--- → fix-optional
Priority: -- → P5
Attachment #8931846 -
Flags: review?(enndeakin)
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → 86ecce74
Status: NEW → ASSIGNED
|
|
||
Updated•7 years ago
|
Attachment #8931846 -
Flags: review?(enndeakin) → review+
|
|
Reporter | |
Comment 2•7 years ago
|
||
|
|
Reporter | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e888131abdcf
Removed button-image binding; r=enndeakin
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•