1416618 - Cannot show short date format (yy/MM/dd'('ddd')') correctly

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[Makoto Kato [:m_kato]]

When format is Japanese on [Region and Language] - [Formats] of Control Panel, it has (yy/MM/dd'('ddd')' for 17/11/13(月) (ddd is short weekly name).

But format shows ddd as date like 17/11/13(013).

Comment 1

[Makoto Kato [:m_kato]]

Attachment: screenshot

Comment 2

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4809e2ae8a737d93383b0fb52a58bf6d6701e1cd

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1416618 - Cannot show short date format (yy/MM/dd'('ddd')') correctly.

On Windows 7, there is yy/mm/dd'('ddd')' as short date format of Japanese.
When selecting this, ddd isn't converted to day of the week correctly.

FindInReadable will update start position iterator even if not found. So when
using FindInReadable again, we have to reset start position iterator.

Review commit: https://reviewboard.mozilla.org/r/199278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199278/

Comment 4

[Jonathan Kew [:jfkthame]]

Comment on attachment 8928049 [details]
Bug 1416618 - Cannot show short date format (yy/MM/dd'('ddd')') correctly.

https://reviewboard.mozilla.org/r/199278/#review204436

Oops!  We should probably consider this for uplift to 58.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26b0f3f9fca1
Cannot show short date format (yy/MM/dd'('ddd')') correctly. r=jfkthame

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/26b0f3f9fca1

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 8928049 [details]
Bug 1416618 - Cannot show short date format (yy/MM/dd'('ddd')') correctly.

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1301640 and bug 1308329

[User impact if declined]:
When user selects short data format like yy/MM/dd'('ddd')' on OS's preference, "ddd" shows day unfortunately.  Correct should be short name of a day of week.  This occurs on file:/// and etc.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes if possible.

- Step
1. Open [Control Panel]
2. [Clock, Language, and Region] - [Region and Language] - [Formats]
3. Select Format: to "Japanese (Japan)" and Short date: yy/MM/dd'('ddd')', then apply [OK]
4. Launch Firefox
5. Navigate to file:///c:/

- Expected result
Date format of each file is like 17/11/16 (Thr), not 17/11/16 (016)

[List of other uplifts needed for the feature/fix]:
Nothing

[Is the change risky?]:
Low

[Why is the change risky/not risky?]:
Set correct iterator to search string.

[String changes made/needed]:
N/A

Comment 8

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on the latest Nightly build? Thanks!

Comment 9

[Hani Yacoub, Desktop QA]

Build ID: 20171116100106
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

Verified as fixed on Firefox Nightly 59.0a1 on Windows 7 x 64.
I couldn't verify it on Windows 10 because I couldn't find short date format like the one indicated above (yy/MM/dd'('ddd')).

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8928049 [details]
Bug 1416618 - Cannot show short date format (yy/MM/dd'('ddd')') correctly.

Fix the date format and was verified. Beta58+.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/125c6999fe56

Comment 12

[Hani Yacoub, Desktop QA]

Build ID: 20171120142222
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox 58.0b5 on Windows 7 x 64.