1416643 - Rework bug 712836

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

We want to run MediaCacheStream::NotifyDataEnded() off the main thread. However, modifying mResourceID/mDidNotifyDataEnded/mNotifyDataEndedStatus in NotifyDataEnded() is getting in our way for they are main thread only members.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1416643. P1 - remove checks for mDidNotifyDataEnded/mNotifyDataEndedStatus from IsAvailableForSharing().

We will need to modify these members off the main thead while IsAvailableForSharing()
is a main thread only function.

InitAsClone() will return an error if the original stream ends abnormally.

Review commit: https://reviewboard.mozilla.org/r/200064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200064/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1416643. P2 - always access mDidNotifyDataEnded within the lock.

Review commit: https://reviewboard.mozilla.org/r/200066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200066/

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8928793 [details]
Bug 1416643. P1 - remove checks for mDidNotifyDataEnded/mNotifyDataEndedStatus from IsAvailableForSharing().

https://reviewboard.mozilla.org/r/200064/#review205204

Comment 4

[Benjamin Chen [:bechen]]

Comment on attachment 8928794 [details]
Bug 1416643. P2 - always access mDidNotifyDataEnded within the lock.

https://reviewboard.mozilla.org/r/200066/#review205206

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

It is worth noting that when mDidNotifyDataEnded/mNotifyDataEndedStatus are modified off the main thread, the result of IsAvailableForSharing() becomes a changing value over time on the main thread. 2 consecutive IsAvailableForSharing() calls on the main thread might return different results.

Even though InitAsClone() is called only after IsAvailableForSharing() returns true, the assertion of MOZ_ASSERT(aOriginal->IsAvailableForSharing()) might still fail for the reason above.

So we need to remove checks for mDidNotifyDataEnded/mNotifyDataEndedStatus from IsAvailableForSharing().

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8928793 [details]
Bug 1416643. P1 - remove checks for mDidNotifyDataEnded/mNotifyDataEndedStatus from IsAvailableForSharing().

https://reviewboard.mozilla.org/r/200064/#review205210

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8928794 [details]
Bug 1416643. P2 - always access mDidNotifyDataEnded within the lock.

https://reviewboard.mozilla.org/r/200066/#review205212

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the reviews!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daaf6edb12f7
P1 - remove checks for mDidNotifyDataEnded/mNotifyDataEndedStatus from IsAvailableForSharing(). r=bechen,gerald
https://hg.mozilla.org/integration/autoland/rev/90cd780b0923
P2 - always access mDidNotifyDataEnded within the lock. r=bechen,gerald

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/daaf6edb12f7
https://hg.mozilla.org/mozilla-central/rev/90cd780b0923