1416665 - [Form Autofill] `contactType` support for filling multiple tel* or email fields

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P3)

Description

[Sean Lee [:seanlee][:weilonge]]

According the spec of autofill[1], `contactType` in the autocomplete attribute is for filling the different email or tel* fields in the different categories.

For the purpose of form autofilling, the feature should be able to help users to fill the correct phone or email based on the contact type.

[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-autocomplete-home

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Hi Mark,

In the current design, the two same field names with the different `contactType` would be considered as the two different fields.
Hence, both of the fields will be filled with the same value based on a selected profile.

Per our offline discussion, we come out these possible solutions to tweak the behavior of the case with `contactType`:
1. Consider the two same field names as the same field type even they are with the different `contactType`.
  - This means the first email or phone number will be filled in one section.

2. Mark the two same field withs the different contactType to the two different sections.
  - This means we have to change the definition of a section.

3. Add the different contact type of phone or email in a profile.
  - This needs more engineering work to implemenet this. It's related to the perferences and dropdown.

Could you provide your ideas? Thank you.

Comment 2

[Mark Liang(:mark_liang)]

We don't want to presume autofilling same value is what users want, so I would suggest not filling the same value for different contactType. This way we'll have the same result if there are two same field names and same autocomplete attribute without contactType.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Hi Mark, Thanks for the opinion. I will use the way of 1 in comment 1.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`.

Review commit: https://reviewboard.mozilla.org/r/200638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200638/

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8929324 [details]
Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`.

https://reviewboard.mozilla.org/r/200638/#review206286

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8929324 [details]
Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200638/diff/1-2/

Comment 7

[Ray Lin[:ralin]]

Comment on attachment 8929324 [details]
Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`.

https://reviewboard.mozilla.org/r/200638/#review206726

LGTM, thanks!

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Thanks for the review.

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8929324 [details]
Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200638/diff/2-3/

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 5e00102facfc -d 11865acd3857: rebasing 435237:5e00102facfc "Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`. r=lchang,ralin" (tip)
other [source] changed browser/extensions/formautofill/test/unit/heuristics/test_multiple_section.js which local [dest] deleted
use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u
merging browser/extensions/formautofill/FormAutofillHeuristics.jsm
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8929324 [details]
Bug 1416665 - Deduplicate the detail with the same field name even they are in the different `contactType`.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200638/diff/3-4/

Comment 12

[Sean Lee [:seanlee][:weilonge]]

The patch is conflict without the one of bug 1415077. The patch is rebased again. Thanks.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/425906b74445
Deduplicate the detail with the same field name even they are in the different `contactType`. r=lchang,ralin

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/425906b74445