Closed Bug 1416682 Opened 8 years ago Closed 8 years ago

Quickly pressing f5 multiple times cause some sites to never load

Categories

(Core :: Networking: Cache, defect, P1)

Product:
Core
Component:
Networking: Cache
Version:
58 Branch
Platform:
Unspecified
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: mauro.doganieri, Assigned: mayhemer)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(3 files)

nytimes.com stuck on loading(Network)
170.47 KB, image/png
Details
nytimes stuck - Devtools Network panel
1022.02 KB, image/png
Details
v1
27.07 KB, patch
michal
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20171112220346 Steps to reproduce: 1. Go to https://www.nytimes.com/ 2. Quickly press f5 multiple times I'm on MacOS 10.13.1 I've reproduced this behavior on a new profile too. Actual results: Site will stuck on an "infinite" loading. If you close the tab and then reopen the same site, it'll continue to infinite loading. To resolve the issue press Command + Shift + R. Expected results: Site should have been refreshed and loaded.
Component: Untriaged → Document Navigation
Product: Firefox → Core
Hi mauro.doganieri, Would you mind please going to about:support, clicking "Copy Text to Clipboard", and pasting that text into a new comment in this bug?
Flags: needinfo?(mauro.doganieri)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hmm, maybe I didn't get exactly that behavior, but bar1_v3.js isn't getting loaded after doing tons of reloads.
and yes, at some point it gets stuck.
(In reply to Mike Conley (:mconley) (:⚙️) - Backlogged on reviews and needinfos from comment #1) > Hi mauro.doganieri, > > Would you mind please going to about:support, clicking "Copy Text to > Clipboard", and pasting that text into a new comment in this bug? Hi Mike, i'm able to reproduce this issue only on the Mac i use at work and unfortunately, at the moment, i'm not at work. I tried to reproduce this issue on my Windows 10 machine at home with Firefox 57 stable but without success. Anyway, i'll paste the info you requested as soon as i get to the office tomorrow morning. If there is something i can do, please let me know.
Flags: needinfo?(mauro.doganieri)
Informazioni di base -------------------- Nome: Firefox Versione: 59.0a1 ID build: 20171113100232 Canale di aggiornamento: nightly User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0 SO: Darwin 17.2.0 Finestre multiprocesso: 1/1 (Attivato automaticamente) Processi contenuti web: 2/4 Stylo: content = true (attivato per impostazione predefinita), chrome = false (disattivato per impostazione predefinita) Chiave Google: Disponibile Chiave per il servizio Mozilla Location: Disponibile Modalità provvisoria: false Segnalazioni di arresto anomalo degli ultimi 3 giorni ----------------------------------------------------- Tutte le segnalazioni Caratteristiche di Nightly -------------------------- Nome: Activity Stream Versione: 2017.11.03.1438-bf427ddd ID: activity-stream@mozilla.org Nome: Application Update Service Helper Versione: 2.0 ID: aushelper@mozilla.org Nome: Firefox Screenshots Versione: 19.2.0 ID: screenshots@mozilla.org Nome: FlyWeb Versione: 1.0.0 ID: flyweb@mozilla.org Nome: Follow-on Search Telemetry Versione: 0.9.6 ID: followonsearch@mozilla.com Nome: Form Autofill Versione: 1.0 ID: formautofill@mozilla.org Nome: Photon onboarding Versione: 1.0 ID: onboarding@mozilla.org Nome: Pocket Versione: 1.0.5 ID: firefox@getpocket.com Nome: Presentation Versione: 1.0.0 ID: presentation@mozilla.org Nome: Shield Recipe Client Versione: 76.1 ID: shield-recipe-client@mozilla.org Nome: Web Compat Versione: 1.1 ID: webcompat@mozilla.org Nome: WebCompat Reporter Versione: 1.0.0 ID: webcompat-reporter@mozilla.org Estensioni ---------- Grafica ------- Caratteristiche Composizione: OpenGL Panoramica/zoom asincroni (APZ): input rotella attivo; trascinamento barre di scorrimento attivo; tastiera attiva; scorrimento automatico attivo Informazioni driver WSI WebGL 1: CGL Renderer driver WebGL 1: Intel Inc. -- Intel Iris OpenGL Engine Versione driver WebGL 1: 4.1 INTEL-10.28.29 Estensioni driver WebGL 1: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier Estensioni WebGL 1: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context Informazioni driver WSI WebGL 2: CGL Renderer driver WebGL 2: Intel Inc. -- Intel Iris OpenGL Engine Versione driver WebGL 2: 4.1 INTEL-10.28.29 Estensioni driver WebGL 2: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier Estensioni WebGL 2: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context GPU #1 Attivo: Sì ID produttore: 0x8086 ID dispositivo: 0x0a2e Diagnostica AzureCanvasAccelerated: 1 AzureCanvasBackend: skia AzureContentBackend: skia AzureFallbackCanvasBackend: none TileHeight: 512 TileWidth: 512 Registro decisioni WEBRENDER: opt-in by default: WebRender is an opt-in feature OMTP: disabled by default: Disabled by default blocked by runtime: OMTP does not yet support tiling Media ----- Back-end audio: audiounit Numero massimo di canali: 2 Layout preferito dei canali: stereo Frequenza di campionamento preferita: 44100 Dispositivi di output Nome: Gruppo Altoparlanti interni: AppleHDAEngineOutput:1B,0,1,2:0 Dispositivi di input Nome: Gruppo Preferenze importanti modificate -------------------------------- accessibility.typeaheadfind.flashBar: 0 browser.cache.disk.capacity: 358400 browser.cache.disk.filesystem_reported: 1 browser.cache.disk.smart_size.first_run: false browser.cache.frecency_experiment: 2 browser.places.smartBookmarksVersion: 8 browser.sessionstore.upgradeBackup.latestBuildID: 20171113100232 browser.startup.homepage: about:home browser.startup.homepage_override.buildID: 20171113100232 browser.startup.homepage_override.mstone: 59.0a1 browser.urlbar.lastSuggestionsPromptDate: 20170831 browser.urlbar.timesBeforeHidingSuggestionsHint: 0 browser.urlbar.usepreloadedtopurls.enabled: false dom.forms.autocomplete.formautofill: true extensions.lastAppVersion: 59.0a1 font.internaluseonly.changed: true media.benchmark.vp9.fps: 151 media.benchmark.vp9.versioncheck: 2 media.gmp-gmpopenh264.abi: x86_64-gcc3 media.gmp-gmpopenh264.lastUpdate: 1508743367 media.gmp-gmpopenh264.version: 1.7.1 media.gmp-manager.buildID: 20171113100232 media.gmp-manager.lastCheck: 1510577651 media.gmp-widevinecdm.abi: x86_64-gcc3 media.gmp-widevinecdm.lastUpdate: 1504511361 media.gmp-widevinecdm.version: 1.4.8.1008 media.gmp.storage.version.observed: 1 network.cookie.prefsMigrated: true network.predictor.cleaned-up: true places.database.lastMaintenance: 1510561421 places.history.expiration.transient_current_max_pages: 91408 plugin.disable_full_page_plugin_for_types: application/pdf print.printer__.print_bgcolor: false print.printer__.print_bgimages: false print.printer__.print_duplex: -437918235 print.printer__.print_edge_bottom: 0 print.printer__.print_edge_left: 0 print.printer__.print_edge_right: 0 print.printer__.print_edge_top: 0 print.printer__.print_evenpages: true print.printer__.print_footercenter: print.printer__.print_footerleft: &PT print.printer__.print_footerright: &D print.printer__.print_headercenter: print.printer__.print_headerleft: &T print.printer__.print_headerright: &U print.printer__.print_in_color: true print.printer__.print_margin_bottom: 0.5 print.printer__.print_margin_left: 0.5 print.printer__.print_margin_right: 0.5 print.printer__.print_margin_top: 0.5 print.printer__.print_oddpages: true print.printer__.print_orientation: 0 print.printer__.print_page_delay: 50 print.printer__.print_paper_data: 0 print.printer__.print_paper_height: 11.69 print.printer__.print_paper_name: iso-a4 print.printer__.print_paper_size_unit: 0 print.printer__.print_paper_width: 8.26 print.printer__.print_resolution: -437918235 print.printer__.print_reversed: false print.printer__.print_scaling: 1.00 print.printer__.print_shrink_to_fit: true print.printer__.print_to_file: false print.printer__.print_unwriteable_margin_bottom: 57 print.printer__.print_unwriteable_margin_left: 25 print.printer__.print_unwriteable_margin_right: 25 print.printer__.print_unwriteable_margin_top: 25 privacy.trackingprotection.enabled: true privacy.trackingprotection.introCount: 20 security.sandbox.content.tempDirSuffix: {70a187f3-5e75-3344-9adb-0340d7a7d4cb} services.sync.declinedEngines: services.sync.engine.addresses.available: true services.sync.engine.creditcards.available: true storage.vacuum.last.index: 0 storage.vacuum.last.places.sqlite: 1510561420 Preferenze importanti bloccate ------------------------------ Database Places --------------- JavaScript ---------- GC incrementale: true Accessibilità ------------- Attivato: false Impedisci accessibilità: 0 Versioni librerie ----------------- NSPR Versione minima prevista: 4.17 Versione in uso: 4.17 NSS Versione minima prevista: 3.34 Beta Versione in uso: 3.34 Beta NSSSMIME Versione minima prevista: 3.34 Beta Versione in uso: 3.34 Beta NSSSSL Versione minima prevista: 3.34 Beta Versione in uso: 3.34 Beta NSSUTIL Versione minima prevista: 3.34 Beta Versione in uso: 3.34 Beta Caratteristiche sperimentali ---------------------------- Sandbox ------- Livello sandbox content process: 3 Livello effettivo sandbox content process: 3 Internazionalizzazione e localizzazione --------------------------------------- Impostazioni dell’applicazione Lingue richieste: ["it","en-US"] Lingue disponibili: ["it"] Lingue applicazione: ["it"] Impostazioni internazionali: ["it-IT"] Lingua predefinita: "it" Sistema operativo Lingue del sistema: ["it-IT"] Impostazioni internazionali: ["it-IT"]
I am able to reproduce this. NI Mike to check comment 5 and here. my about:support === Application Basics ------------------ Name: Firefox Version: 58.0a1 Build ID: 20171109220104 Update Channel: nightly User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:58.0) Gecko/20100101 Firefox/58.0 OS: Darwin 15.6.0 Multiprocess Windows: 2/2 (Enabled by default) Web Content Processes: 4/4 Stylo: content = true (enabled by default), chrome = false (disabled by default) Google Key: Found Mozilla Location Service Key: Found Safe Mode: false Crash Reports for the Last 3 Days --------------------------------- All Crash Reports Nightly Features ---------------- Name: Activity Stream Version: 2017.11.03.1438-bf427ddd ID: activity-stream@mozilla.org Name: Application Update Service Helper Version: 2.0 ID: aushelper@mozilla.org Name: Firefox Screenshots Version: 19.2.0 ID: screenshots@mozilla.org Name: FlyWeb Version: 1.0.0 ID: flyweb@mozilla.org Name: Follow-on Search Telemetry Version: 0.9.6 ID: followonsearch@mozilla.com Name: Form Autofill Version: 1.0 ID: formautofill@mozilla.org Name: Photon onboarding Version: 1.0 ID: onboarding@mozilla.org Name: Pocket Version: 1.0.5 ID: firefox@getpocket.com Name: Presentation Version: 1.0.0 ID: presentation@mozilla.org Name: Shield Recipe Client Version: 76.1 ID: shield-recipe-client@mozilla.org Name: Web Compat Version: 1.1 ID: webcompat@mozilla.org Name: WebCompat Reporter Version: 1.0.0 ID: webcompat-reporter@mozilla.org Extensions ---------- Name: Gecko Profiler Version: 0.17 Enabled: true ID: geckoprofiler@mozilla.com Name: JavaScript Toggle On and Off (WebExtension) Version: 0.1.8 Enabled: true ID: {479f0278-2c34-4365-b9f0-1d328d0f0a40} Name: Test Pilot Version: 2.0.6-dev-873d590 Enabled: true ID: @testpilot-addon Name: Triage with me Version: 0.9 Enabled: true ID: jid0-skldjfhalkjsdhfauwyertwuy3rt@jetpack Name: Tab Center Version: 1.36.0 Enabled: false ID: tabcentertest1@mozilla.com Graphics -------- Features Compositing: OpenGL Asynchronous Pan/Zoom: none WebGL 1 Driver WSI Info: CGL WebGL 1 Driver Renderer: Intel Inc. -- Intel(R) Iris(TM) Graphics 6100 WebGL 1 Driver Version: 4.1 INTEL-10.14.73 WebGL 1 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context WebGL 2 Driver WSI Info: CGL WebGL 2 Driver Renderer: Intel Inc. -- Intel(R) Iris(TM) Graphics 6100 WebGL 2 Driver Version: 4.1 INTEL-10.14.73 WebGL 2 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context GPU #1 Active: Yes Vendor ID: 0x8086 Device ID: 0x162b Diagnostics AzureCanvasAccelerated: 1 AzureCanvasBackend: skia AzureContentBackend: skia AzureFallbackCanvasBackend: none TileHeight: 1024 TileWidth: 1024 Decision Log WEBRENDER: opt-in by default: WebRender is an opt-in feature OMTP: disabled by default: Disabled by default blocked by runtime: OMTP does not yet support tiling Media ----- Audio Backend: audiounit Max Channels: 2 Preferred Channel Layout: stereo Preferred Sample Rate: 44100 Output Devices Name: Group Headphones: AppleHDAEngineOutput:1B,0,1,1:0 Input Devices Name: Group Internal Microphone: AppleHDAEngineInput:1B,0,1,0:1 Important Modified Preferences ------------------------------ accessibility.browsewithcaret: true accessibility.typeaheadfind: true accessibility.typeaheadfind.flashBar: 0 browser.cache.disk.capacity: 61440 browser.cache.disk.filesystem_reported: 1 browser.cache.disk.hashstats_reported: 1 browser.cache.disk.smart_size.first_run: false browser.cache.disk.smart_size.use_old_max: false browser.cache.frecency_experiment: 4 browser.download.useDownloadDir: false browser.places.smartBookmarksVersion: 8 browser.sessionstore.upgradeBackup.latestBuildID: 20171109220104 browser.startup.homepage_override.buildID: 20171109220104 browser.startup.homepage_override.mstone: 58.0a1 browser.tabs.animate: false browser.tabs.crashReporting.includeURL: true browser.tabs.remote.autostart.2: false browser.urlbar.searchSuggestionsChoice: true browser.urlbar.usepreloadedtopurls.enabled: false browser.urlbar.userMadeSearchSuggestionsChoice: true dom.apps.lastUpdate.buildID: 20161019084923 dom.apps.lastUpdate.mstone: 49.0.2 dom.apps.reset-permissions: true dom.disable_open_during_load: false dom.forms.autocomplete.formautofill: true dom.forms.datetime.others: true dom.linkPrerender.enabled: true dom.moduleScripts.enabled: true dom.mozApps.used: true dom.payments.request.enabled: true dom.push.loglevel: debug dom.push.userAgentID: 6b77896333ab457db1253c995a7d0863 dom.w3c_touch_events.enabled: 2 dom.webcomponents.customelements.enabled: true dom.webcomponents.enabled: true extensions.lastAppVersion: 58.0a1 font.internaluseonly.changed: false gfx.blacklist.direct2d.failureid: FEATURE_FAILURE_DL_BLACKLIST_g984 gfx.blacklist.hardwarevideodecoding.failureid: FEATURE_FAILURE_DL_BLACKLIST_g1208 gfx.crash-guard.glcontext.appVersion: 45.0.1 gfx.crash-guard.glcontext.deviceID: 0x162b gfx.crash-guard.status.glcontext: 2 javascript.options.asyncstack: false layers.async-pan-zoom.enabled: false media.benchmark.vp9.fps: 137 media.benchmark.vp9.versioncheck: 2 media.gmp-gmpopenh264.abi: x86_64-gcc3 media.gmp-gmpopenh264.lastUpdate: 1508725635 media.gmp-gmpopenh264.version: 1.7.1 media.gmp-manager.buildID: 20171109220104 media.gmp-manager.lastCheck: 1510282683 media.gmp-widevinecdm.abi: x86_64-gcc3 media.gmp-widevinecdm.lastUpdate: 1504232010 media.gmp-widevinecdm.version: 1.4.8.1008 media.gmp.storage.version.observed: 1 media.webrtc.debug.aec_log_dir: /tmp/ media.webrtc.debug.log_file: /tmp/WebRTC.log network.auth.allow-subresource-auth: 2 network.cookie.prefsMigrated: true network.predictor.cleaned-up: true places.database.lastMaintenance: 1510277622 places.history.expiration.transient_current_max_pages: 64418 plugin.disable_full_page_plugin_for_types: application/pdf plugin.importedState: true plugins.ctprollout.cohort: test plugins.ctprollout.cohortSample: 0.414647 print.print_bgcolor: false print.print_bgimages: false print.print_duplex: -437918235 print.print_evenpages: true print.print_in_color: true print.print_margin_bottom: 0.5 print.print_margin_left: 0.5 print.print_margin_right: 0.5 print.print_margin_top: 0.5 print.print_oddpages: true print.print_orientation: 0 print.print_page_delay: 50 print.print_paper_data: 0 print.print_paper_height: 11.00 print.print_paper_name: print.print_paper_size_unit: 0 print.print_paper_width: 8.50 print.print_resolution: -437918235 print.print_reversed: false print.print_scaling: 1.00 print.print_shrink_to_fit: true print.print_to_file: false print.print_unwriteable_margin_bottom: 20 print.print_unwriteable_margin_left: 20 print.print_unwriteable_margin_right: 20 print.print_unwriteable_margin_top: 20 print.printer__.print_bgcolor: false print.printer__.print_bgimages: false print.printer__.print_duplex: -437918235 print.printer__.print_edge_bottom: 0 print.printer__.print_edge_left: 0 print.printer__.print_edge_right: 0 print.printer__.print_edge_top: 0 print.printer__.print_evenpages: true print.printer__.print_footercenter: print.printer__.print_footerleft: &PT print.printer__.print_footerright: &D print.printer__.print_headercenter: print.printer__.print_headerleft: &T print.printer__.print_headerright: &U print.printer__.print_in_color: true print.printer__.print_margin_bottom: 0.5 print.printer__.print_margin_left: 0.5 print.printer__.print_margin_right: 0.5 print.printer__.print_margin_top: 0.5 print.printer__.print_oddpages: true print.printer__.print_orientation: 0 print.printer__.print_page_delay: 50 print.printer__.print_paper_data: 0 print.printer__.print_paper_height: 11.69 print.printer__.print_paper_name: iso-a4 print.printer__.print_paper_size_unit: 0 print.printer__.print_paper_width: 8.26 print.printer__.print_resolution: -437918235 print.printer__.print_reversed: false print.printer__.print_scaling: 1.00 print.printer__.print_shrink_to_fit: true print.printer__.print_to_file: false print.printer__.print_unwriteable_margin_bottom: 20 print.printer__.print_unwriteable_margin_left: 20 print.printer__.print_unwriteable_margin_right: 20 print.printer__.print_unwriteable_margin_top: 20 print.printer_Mozilla_Printer_4F.print_bgcolor: false print.printer_Mozilla_Printer_4F.print_bgimages: false print.printer_Mozilla_Printer_4F.print_duplex: -437918235 print.printer_Mozilla_Printer_4F.print_edge_bottom: 0 print.printer_Mozilla_Printer_4F.print_edge_left: 0 print.printer_Mozilla_Printer_4F.print_edge_right: 0 print.printer_Mozilla_Printer_4F.print_edge_top: 0 print.printer_Mozilla_Printer_4F.print_evenpages: true print.printer_Mozilla_Printer_4F.print_footercenter: print.printer_Mozilla_Printer_4F.print_footerleft: &PT print.printer_Mozilla_Printer_4F.print_footerright: &D print.printer_Mozilla_Printer_4F.print_headercenter: print.printer_Mozilla_Printer_4F.print_headerleft: &T print.printer_Mozilla_Printer_4F.print_headerright: &U print.printer_Mozilla_Printer_4F.print_in_color: true print.printer_Mozilla_Printer_4F.print_margin_bottom: 0.5 print.printer_Mozilla_Printer_4F.print_margin_left: 0.5 print.printer_Mozilla_Printer_4F.print_margin_right: 0.5 print.printer_Mozilla_Printer_4F.print_margin_top: 0.5 print.printer_Mozilla_Printer_4F.print_oddpages: true print.printer_Mozilla_Printer_4F.print_orientation: 0 print.printer_Mozilla_Printer_4F.print_page_delay: 50 print.printer_Mozilla_Printer_4F.print_paper_data: 0 print.printer_Mozilla_Printer_4F.print_paper_height: 11.69 print.printer_Mozilla_Printer_4F.print_paper_name: iso-a4 print.printer_Mozilla_Printer_4F.print_paper_size_unit: 0 print.printer_Mozilla_Printer_4F.print_paper_width: 8.26 print.printer_Mozilla_Printer_4F.print_resolution: -437918235 print.printer_Mozilla_Printer_4F.print_reversed: false print.printer_Mozilla_Printer_4F.print_scaling: 1.00 print.printer_Mozilla_Printer_4F.print_shrink_to_fit: true print.printer_Mozilla_Printer_4F.print_to_file: false print.printer_Mozilla_Printer_4F.print_unwriteable_margin_bottom: 20 print.printer_Mozilla_Printer_4F.print_unwriteable_margin_left: 20 print.printer_Mozilla_Printer_4F.print_unwriteable_margin_right: 20 print.printer_Mozilla_Printer_4F.print_unwriteable_margin_top: 20 print.printer_Mozilla_Printer1_ir2525.print_bgcolor: false print.printer_Mozilla_Printer1_ir2525.print_bgimages: false print.printer_Mozilla_Printer1_ir2525.print_duplex: -437918235 print.printer_Mozilla_Printer1_ir2525.print_edge_bottom: 0 print.printer_Mozilla_Printer1_ir2525.print_edge_left: 0 print.printer_Mozilla_Printer1_ir2525.print_edge_right: 0 print.printer_Mozilla_Printer1_ir2525.print_edge_top: 0 print.printer_Mozilla_Printer1_ir2525.print_evenpages: true print.printer_Mozilla_Printer1_ir2525.print_footercenter: print.printer_Mozilla_Printer1_ir2525.print_footerleft: &PT print.printer_Mozilla_Printer1_ir2525.print_footerright: &D print.printer_Mozilla_Printer1_ir2525.print_headercenter: print.printer_Mozilla_Printer1_ir2525.print_headerleft: &T print.printer_Mozilla_Printer1_ir2525.print_headerright: &U print.printer_Mozilla_Printer1_ir2525.print_in_color: true print.printer_Mozilla_Printer1_ir2525.print_margin_bottom: 0.5 print.printer_Mozilla_Printer1_ir2525.print_margin_left: 0.5 print.printer_Mozilla_Printer1_ir2525.print_margin_right: 0.5 print.printer_Mozilla_Printer1_ir2525.print_margin_top: 0.5 print.printer_Mozilla_Printer1_ir2525.print_oddpages: true print.printer_Mozilla_Printer1_ir2525.print_orientation: 0 print.printer_Mozilla_Printer1_ir2525.print_page_delay: 50 print.printer_Mozilla_Printer1_ir2525.print_paper_data: 0 print.printer_Mozilla_Printer1_ir2525.print_paper_height: 11.69 print.printer_Mozilla_Printer1_ir2525.print_paper_name: iso-a4 print.printer_Mozilla_Printer1_ir2525.print_paper_size_unit: 0 print.printer_Mozilla_Printer1_ir2525.print_paper_width: 8.26 print.printer_Mozilla_Printer1_ir2525.print_resolution: -437918235 print.printer_Mozilla_Printer1_ir2525.print_reversed: false print.printer_Mozilla_Printer1_ir2525.print_scaling: 1.00 print.printer_Mozilla_Printer1_ir2525.print_shrink_to_fit: true print.printer_Mozilla_Printer1_ir2525.print_to_file: false print.printer_Mozilla_Printer1_ir2525.print_unwriteable_margin_bottom: 20 print.printer_Mozilla_Printer1_ir2525.print_unwriteable_margin_left: 20 print.printer_Mozilla_Printer1_ir2525.print_unwriteable_margin_right: 20 print.printer_Mozilla_Printer1_ir2525.print_unwriteable_margin_top: 20 print.printer_Mozilla_TPE_4F.print_bgcolor: false print.printer_Mozilla_TPE_4F.print_bgimages: false print.printer_Mozilla_TPE_4F.print_duplex: -437918235 print.printer_Mozilla_TPE_4F.print_edge_bottom: 0 print.printer_Mozilla_TPE_4F.print_edge_left: 0 print.printer_Mozilla_TPE_4F.print_edge_right: 0 print.printer_Mozilla_TPE_4F.print_edge_top: 0 print.printer_Mozilla_TPE_4F.print_evenpages: true print.printer_Mozilla_TPE_4F.print_footercenter: print.printer_Mozilla_TPE_4F.print_footerleft: &PT print.printer_Mozilla_TPE_4F.print_footerright: &D print.printer_Mozilla_TPE_4F.print_headercenter: print.printer_Mozilla_TPE_4F.print_headerleft: &T print.printer_Mozilla_TPE_4F.print_headerright: &U print.printer_Mozilla_TPE_4F.print_in_color: true print.printer_Mozilla_TPE_4F.print_margin_bottom: 0.5 print.printer_Mozilla_TPE_4F.print_margin_left: 0.5 print.printer_Mozilla_TPE_4F.print_margin_right: 0.5 print.printer_Mozilla_TPE_4F.print_margin_top: 0.5 print.printer_Mozilla_TPE_4F.print_oddpages: true print.printer_Mozilla_TPE_4F.print_orientation: 0 print.printer_Mozilla_TPE_4F.print_page_delay: 50 print.printer_Mozilla_TPE_4F.print_paper_data: 0 print.printer_Mozilla_TPE_4F.print_paper_height: 11.69 print.printer_Mozilla_TPE_4F.print_paper_name: iso-a4 print.printer_Mozilla_TPE_4F.print_paper_size_unit: 0 print.printer_Mozilla_TPE_4F.print_paper_width: 8.26 print.printer_Mozilla_TPE_4F.print_resolution: -437918235 print.printer_Mozilla_TPE_4F.print_reversed: false print.printer_Mozilla_TPE_4F.print_scaling: 1.00 print.printer_Mozilla_TPE_4F.print_shrink_to_fit: true print.printer_Mozilla_TPE_4F.print_to_file: false print.printer_Mozilla_TPE_4F.print_unwriteable_margin_bottom: 23 print.printer_Mozilla_TPE_4F.print_unwriteable_margin_left: 23 print.printer_Mozilla_TPE_4F.print_unwriteable_margin_right: 23 print.printer_Mozilla_TPE_4F.print_unwriteable_margin_top: 23 print.printer_Mozilla_TPE_5F.print_bgcolor: false print.printer_Mozilla_TPE_5F.print_bgimages: false print.printer_Mozilla_TPE_5F.print_duplex: -437918235 print.printer_Mozilla_TPE_5F.print_edge_bottom: 0 print.printer_Mozilla_TPE_5F.print_edge_left: 0 print.printer_Mozilla_TPE_5F.print_edge_right: 0 print.printer_Mozilla_TPE_5F.print_edge_top: 0 print.printer_Mozilla_TPE_5F.print_evenpages: true print.printer_Mozilla_TPE_5F.print_footercenter: print.printer_Mozilla_TPE_5F.print_footerleft: &PT print.printer_Mozilla_TPE_5F.print_footerright: &D print.printer_Mozilla_TPE_5F.print_headercenter: print.printer_Mozilla_TPE_5F.print_headerleft: &T print.printer_Mozilla_TPE_5F.print_headerright: &U print.printer_Mozilla_TPE_5F.print_in_color: true print.printer_Mozilla_TPE_5F.print_margin_bottom: 0.5 print.printer_Mozilla_TPE_5F.print_margin_left: 0.5 print.printer_Mozilla_TPE_5F.print_margin_right: 0.5 print.printer_Mozilla_TPE_5F.print_margin_top: 0.5 print.printer_Mozilla_TPE_5F.print_oddpages: true print.printer_Mozilla_TPE_5F.print_orientation: 0 print.printer_Mozilla_TPE_5F.print_page_delay: 50 print.printer_Mozilla_TPE_5F.print_paper_data: 0 print.printer_Mozilla_TPE_5F.print_paper_height: 11.69 print.printer_Mozilla_TPE_5F.print_paper_name: iso-a4 print.printer_Mozilla_TPE_5F.print_paper_size_unit: 0 print.printer_Mozilla_TPE_5F.print_paper_width: 8.26 print.printer_Mozilla_TPE_5F.print_resolution: -437918235 print.printer_Mozilla_TPE_5F.print_reversed: false print.printer_Mozilla_TPE_5F.print_scaling: 1.00 print.printer_Mozilla_TPE_5F.print_shrink_to_fit: true print.printer_Mozilla_TPE_5F.print_to_file: false print.printer_Mozilla_TPE_5F.print_unwriteable_margin_bottom: 20 print.printer_Mozilla_TPE_5F.print_unwriteable_margin_left: 20 print.printer_Mozilla_TPE_5F.print_unwriteable_margin_right: 20 print.printer_Mozilla_TPE_5F.print_unwriteable_margin_top: 20 print.printer_TPE4-Rainbow.print_bgcolor: false print.printer_TPE4-Rainbow.print_bgimages: false print.printer_TPE4-Rainbow.print_duplex: -437918235 print.printer_TPE4-Rainbow.print_edge_bottom: 0 print.printer_TPE4-Rainbow.print_edge_left: 0 print.printer_TPE4-Rainbow.print_edge_right: 0 print.printer_TPE4-Rainbow.print_edge_top: 0 print.printer_TPE4-Rainbow.print_evenpages: true print.printer_TPE4-Rainbow.print_footercenter: print.printer_TPE4-Rainbow.print_footerleft: &PT print.printer_TPE4-Rainbow.print_footerright: &D print.printer_TPE4-Rainbow.print_headercenter: print.printer_TPE4-Rainbow.print_headerleft: &T print.printer_TPE4-Rainbow.print_headerright: &U print.printer_TPE4-Rainbow.print_in_color: true print.printer_TPE4-Rainbow.print_margin_bottom: 0.5 print.printer_TPE4-Rainbow.print_margin_left: 0.5 print.printer_TPE4-Rainbow.print_margin_right: 0.5 print.printer_TPE4-Rainbow.print_margin_top: 0.5 print.printer_TPE4-Rainbow.print_oddpages: true print.printer_TPE4-Rainbow.print_orientation: 0 print.printer_TPE4-Rainbow.print_page_delay: 50 print.printer_TPE4-Rainbow.print_paper_data: 0 print.printer_TPE4-Rainbow.print_paper_height: 11.69 print.printer_TPE4-Rainbow.print_paper_name: iso-a4 print.printer_TPE4-Rainbow.print_paper_size_unit: 0 print.printer_TPE4-Rainbow.print_paper_width: 8.27 print.printer_TPE4-Rainbow.print_resolution: -437918235 print.printer_TPE4-Rainbow.print_reversed: false print.printer_TPE4-Rainbow.print_scaling: 1.00 print.printer_TPE4-Rainbow.print_shrink_to_fit: true print.printer_TPE4-Rainbow.print_to_file: false print.printer_TPE4-Rainbow.print_unwriteable_margin_bottom: 17 print.printer_TPE4-Rainbow.print_unwriteable_margin_left: 17 print.printer_TPE4-Rainbow.print_unwriteable_margin_right: 17 print.printer_TPE4-Rainbow.print_unwriteable_margin_top: 17 privacy.sanitize.migrateClearSavedPwdsOnExit: true privacy.sanitize.migrateFx3Prefs: true privacy.sanitize.timeSpan: 2 security.sandbox.content.tempDirSuffix: {fe410437-faa6-4341-8618-a60d0eb2dbe7} security.tls.insecure_fallback_hosts: sslpayment.uwccb.com.tw services.sync.declinedEngines: services.sync.engine.adblockplus: true services.sync.engine.addresses.available: true services.sync.engine.creditcards.available: true storage.vacuum.last.index: 1 storage.vacuum.last.places.sqlite: 1509665877 Important Locked Preferences ---------------------------- Places Database --------------- JavaScript ---------- Incremental GC: true Accessibility ------------- Activated: false Prevent Accessibility: 0 Library Versions ---------------- NSPR Expected minimum version: 4.17 Version in use: 4.17 NSS Expected minimum version: 3.34 Beta Version in use: 3.34 Beta NSSSMIME Expected minimum version: 3.34 Beta Version in use: 3.34 Beta NSSSSL Expected minimum version: 3.34 Beta Version in use: 3.34 Beta NSSUTIL Expected minimum version: 3.34 Beta Version in use: 3.34 Beta Experimental Features --------------------- Sandbox ------- Content Process Sandbox Level: 3 Effective Content Process Sandbox Level: 3 Internationalization & Localization ----------------------------------- Application Settings Requested Locales: ["en-US"] Available Locales: ["en-US"] App Locales: ["en-US"] Regional Preferences: ["en-TW"] Default Locale: "en-US" Operating System System Locales: ["en-TW"] Regional Preferences: ["en-TW"] ===
Flags: needinfo?(mconley)
OS: Unspecified → Mac OS X
I'm unfortunately still unable to reproduce this. https://www.nytimes.com finishes loading for me after rapid pressing of F5 after a few seconds and the throbber goes away. For the people who are able to reproduce this, does the Network panel in Developer Tools show any requests still in flight when you're in this state? Perhaps bar1_v3.js isn't loading, like smaug experienced in comment 2?
Flags: needinfo?(mconley) → needinfo?(htsai)
I didn't manage to reproduce this again with tens of trials. :(
Flags: needinfo?(htsai)
Priority: -- → P3
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #9) > I didn't manage to reproduce this again with tens of trials. :( Hi Hsin-Yi Tsai, are you trying to reproduce this with dev tools open? I'm asking this because it seems that i'm not able anymore to reproduce this with dev tools open, instead i'm still able to do it with dev tools closed. I can't say if it's a coincidence, i tried multiple times both of the above methods and i was only able to reproduce the issue(multiple times) in the second case.
(In reply to mauro.doganieri from comment #10) > (In reply to Hsin-Yi Tsai [:hsinyi] from comment #9) > > I didn't manage to reproduce this again with tens of trials. :( > > Hi Hsin-Yi Tsai, are you trying to reproduce this with dev tools open? > I'm asking this because it seems that i'm not able anymore to reproduce this > with dev tools open, instead i'm still able to do it with dev tools closed. > I can't say if it's a coincidence, i tried multiple times both of the above > methods and i was only able to reproduce the issue(multiple times) in the > second case. Good finding! Right, I tried to reproduce this with devtools open. With devtools closed, I am now able to reproduce this easily. When the issue happened, right click didn't function that context menu wasn't shown.
Hm, okay, thanks. I wonder if this is a bug somewhere in the networking layer. Hey dragana, have you heard of anything like this bug? Is there any network logging that'd be useful to try to figure out what's happening here?
Flags: needinfo?(dd.mozilla)
Can someone capture a http log for this: https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging
Flags: needinfo?(mauro.doganieri)
Flags: needinfo?(htsai)
Flags: needinfo?(dd.mozilla)
(In reply to Dragana Damjanovic [:dragana] from comment #14) > Can someone capture a http log for this: > https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging Hi Dragana, i captured a http log reproducing the issue but i wasn't able to attach here the file beacause it's quite big. I created a share link from my Dropbox, hope there are no problems with it: https://www.dropbox.com/s/1vef9agmctsoljd/log.txt-main.491?dl=0
Flags: needinfo?(mauro.doganieri)
Sorry that my Mac was sent for repairs that I don't have one at hand. I'll try to get the log once my Mac is back.
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #17) > Sorry that my Mac was sent for repairs that I don't have one at hand. I'll > try to get the log once my Mac is back. one log is enough. no worries.
Flags: needinfo?(htsai)
Only thing I have discovered is that https://a1.nyt.com/assets/homepage/20171106-114620/js/foundation/lib/framework.js does not get loaded. I manage to reproduce the issue myself. relevant log: 2017-11-29 08:43:20.483261 UTC - [Main Thread]: D/nsHttp nsHttpChannel::Connect 0x158bba000 AwaitingCacheCallbacks forces async 2017-11-29 08:43:20.483280 UTC - [Main Thread]: D/nsHttp nsHttpChannel::ContinueBeginConnectWithResult result [this=0x158bba000 rv=0 mCanceled=0] 2017-11-29 08:43:20.483295 UTC - [Main Thread]: D/nsHttp nsHttpChannel::Starting nsChannelClassifier 0x125f6f040 [this=0x158bba000] nsHttpChannel @158bba000 --> nsChannelClassifier @125f6f040 2017-11-29 08:43:20.483334 UTC - [Main Thread]: D/nsHttp nsHttpChannel::SuspendInternal [this=0x158bba000] 2017-11-29 08:43:20.484665 UTC - [Main Thread]: D/nsHttp nsHttpChannel::ResumeInternal [this=0x158bba000] ... 2017-11-29 08:43:20.492381 UTC - [Main Thread]: D/nsHttp nsHttpChannel::OnLookupComplete [this=0x158bba000] prefetch complete, refresh requested: success status[0x0] that is all I see for this resource. It looks like the cache never responds. I will try to make a log with cache2:5
Honza, I will send you a log per e-mail. Can you please take a look? (also see comment 19)
Flags: needinfo?(honzab.moz)
Component: Document Navigation → Networking: Cache
Priority: P3 → P1
Whiteboard: [necko-triaged]
Thanks for the log. There is one channel that is revalidating a JS script (it's important). The channel and the conditional request transaction are canceled (thanks the quick reload) before the validation request is received. The channel calls CloseCacheEntry, which is releasing the entry handle. But, the JS engine is apparently holding another reference and does it so indefinitely from some reason. This makes the naive cache back-end believe the entry is still being validated. This could be fixed in the JS engine, but a general solution inside the cache is probably more appropriate. See also bug 1340197, which has a somewhat similar cause (in that case a channel leak hangs the cache). So, I think we have to add a new method in nsICacheEntry to indicate EXPLICITLY that an http channel no longer want to deal with the entry and throws it away. The internal state of the entry may reflect that, for the sake of this bug revert the state from REVALIDATING to READY so that the next consumer can use it again.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Flags: needinfo?(honzab.moz)
Attached patch v1 — — Splinter Review
exactly 3 things: - deCOM of CacheEntry class (no longer derives from nsICacheEntry, consumer access only via CacheEntryHandler : nsICacheEntry) because I need to have a method with a specific code on CacheEntryHandle (no perf change tho, since the handle was referring CacheEntry and CacheEntry was already marked final) - new nsICacheEntry::Dismiss method that, when called, behaves as if the handle were released (reverts the entry's state: WRITING -> EMPTY, REVALIDATING -> READY + fires next callback) but still keeps the reference, so that the entry doesn't go away from memory and cannot be duplicated for the same scope+URI - nsHttpChannel::CloseCacheEntry calls Dismiss() before the entry is released, so that if anyone else keeps a reference to the handle, we behave as if the entry were released I think this is a safe enough and correct fix. I was able to repro the issue quite easily w/o the patch and was not able w/ the patch. I unfortunately have not added this to nsHttpChannel::Cancel, since it broke a lot of things as I expected. cancellation doesn't ensure the channel later doesn't touch the entry (like marking it ready or whatever header operations). For the case of bug 1340197 - it's simply a bad thing to suspend a channel and then cancel it w/o resuming it. https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a66bcfd656f22c9f7e42a260c7a6b609744d6e1
Attachment #8933441 - Flags: review?(michal.novotny)
To be more precise, the entry is held by HttpChannelParent and not released because the child prefers an alt-data type, see [1]. Hence, other solution (tho, very specific one) would be add && NS_SUCCEEDED(channelStatus) to that specific condition at [1]. [1] https://dxr.mozilla.org/mozilla-central/rev/ba283baf4e98aa3a5f45a17981077b98697aa73a/netwerk/protocol/http/HttpChannelChild.cpp#1108 Michal, what do you think?
Flags: needinfo?(michal.novotny)
(In reply to Honza Bambas (:mayhemer) from comment #23) > To be more precise, the entry is held by HttpChannelParent and not released > because the child prefers an alt-data type, see [1]. > > Hence, other solution (tho, very specific one) would be add && > NS_SUCCEEDED(channelStatus) to that specific condition at [1]. Yes, this definitely makes sense because alt-data won't be accessed if the channel doesn't succeed. Could it happen that we won't validate the entry even if channelStatus is a success code?
Flags: needinfo?(michal.novotny)
(In reply to Michal Novotny (:michal) from comment #24) > channel doesn't succeed. Could it happen that we won't validate the entry > even if channelStatus is a success code? That's hard to answer. E.g. in case we get 200 instead of 304 we doom the entry and create a new one. In case of e.g. 500 I'm not sure, but we definitely not call SetValid() on the entry. Question is, which fix is better or if we should take both of them.
Attachment #8933441 - Flags: review?(michal.novotny) → review+
(In reply to Honza Bambas (:mayhemer) from comment #25) > (In reply to Michal Novotny (:michal) from comment #24) > > channel doesn't succeed. Could it happen that we won't validate the entry > > even if channelStatus is a success code? > > That's hard to answer. E.g. in case we get 200 instead of 304 we doom the > entry and create a new one. In case of e.g. 500 I'm not sure, but we > definitely not call SetValid() on the entry. > > Question is, which fix is better or if we should take both of them. I think we should take both.
(In reply to Michal Novotny (:michal) from comment #26) > I think we should take both. Thanks. Will file a separate bug for that.
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/79dda82f07c4 Add nsICacheEntry.drop() to explicitly release HTTP cache entries from channels to avoid logical deadlocks, r=michal
Keywords: checkin-needed
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d9fb1d761acf Don't allow writing alt-data to HTTP cache entry when the loading channel has failed to release the entry, r=michal
(In reply to Pulsebot from comment #30) > Pushed by shindli@mozilla.com: > https://hg.mozilla.org/integration/mozilla-inbound/rev/d9fb1d761acf > Don't allow writing alt-data to HTTP cache entry when the loading channel > has failed to release the entry, r=michal This changeset actually belongs to bug 1422381. I screwed up the bug number in the commit message.
See Also: → 1422381
https://hg.mozilla.org/mozilla-central/rev/79dda82f07c4 https://hg.mozilla.org/mozilla-central/rev/d9fb1d761acf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: