1416689 - frame dump code in nsIFrame::ListGeneric() is wrong

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Bug 1416689 - fix frame dump code in nsIFrame::ListGeneric.

I believe this is a typo. This fix will not affect the existing frame dump result
because the input parameter, i.e., aTo, has been initialized to empty string by
the caller before calling. So, the first line of nsIFrame::ListGeneric can be
written as:

a) aTo =+ aPrefix;
b) aTo += aPrefix;
c) aTo = aPrefix;

and all three results are the same at present.

In this patch, we fix the typo by choosing (b) to make it align the rest parts
of nsIFrame::ListGeneric.

Review commit: https://reviewboard.mozilla.org/r/199044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199044/

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8927763 [details]
Bug 1416689 - fix frame dump code in nsIFrame::ListGeneric.

https://reviewboard.mozilla.org/r/199044/#review204060

Nice catch. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17326b960a52
fix frame dump code in nsIFrame::ListGeneric. r=TYLin

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/17326b960a52

Comment 5

[Gerry Chang [:gchang]]

Won't fix for 58. Let it ride the train.