1416703 - Remove dead prefs in all.js

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Cervantes Yu [:cyu] [:cervantes]]

This bug is opened for tracking the removal of dead prefs in all.js

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead accessibility prefs

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead prefs for printing

Comment 3

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead media prefs

Note that "media.getusermedia.aec_delay_agnostic" is in effect a dead pref because there is a typo (redundant "aec") in https://searchfox.org/mozilla-central/source/dom/media/MediaManager.cpp#3057. Do we still need to keep this pref?

Comment 4

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead devtools prefs

Comment 5

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead prefs for profile management

Comment 6

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead gfx prefs

Comment 7

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Removes from all.js some dom, browser, autocomplete, ui, and other prefs that are dead

Comment 8

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead security prefs

Comment 9

[:Gijs (he/him)]

Comment on attachment 8928133 [details] [diff] [review]
Remove dead accessibility prefs

Review of attachment 8928133 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ -977,5 @@
>  pref("accessibility.accesskeycausesactivation", true);
>  pref("accessibility.mouse_focuses_formcontrol", false);
>  
>  // Type Ahead Find
> -pref("accessibility.typeaheadfind", true);

This is still used, and I don't really understand why you think it is unused. It's even synced and has UI. If you're trying to dedupe this with browser's firefox.js file, the correct way to do that, IMO, would be to move the default value in browser to this file and rm the override in browser (in which case it would be courteous to notify fennec/mailnews and/or other consumers in case they care about the change in default).

Comment 10

[Julian Descottes [:jdescottes]]

Comment on attachment 8928137 [details] [diff] [review]
Remove dead devtools prefs

Review of attachment 8928137 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, none of them are used anymore.

Comment 11

[Marco Bonardo [:mak]]

Comment on attachment 8928138 [details] [diff] [review]
Remove dead prefs for profile management

Review of attachment 8928138 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ -2815,5 @@
> -// if -1, we never think your profile is defunct
> -// and users will never see the remigrate UI.
> -pref("profile.seconds_until_defunct", -1);
> -// We can show it anytime from menus
> -pref("profile.manage_only_at_launch", false);

This one looks used by Suite:
https://dxr.mozilla.org/comm-central/source/suite/common/profile/profileSelection.js#48
, you should file a separate bug for it, to move it to the Suite relevant pref file

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 8928142 [details] [diff] [review]
Remove dead security prefs

Review of attachment 8928142 [details] [diff] [review]:
-----------------------------------------------------------------

r=dveditz

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8928136 [details] [diff] [review]
Remove dead media prefs

Review of attachment 8928136 [details] [diff] [review]:
-----------------------------------------------------------------

Some of these prefs are for WebRTC, Jesup should look at them.

::: modules/libpref/init/all.js
@@ -414,5 @@
>  #ifdef MOZ_APPLEMEDIA
>  #ifdef MOZ_WIDGET_UIKIT
>  pref("media.mp3.enabled", true);
>  #endif
>  pref("media.apple.mp3.enabled", true);

media.apple.mp3.enabled is only used once:

https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/dom/media/test/test_can_play_type_mpeg.html#168

We support MP3 on all versions of MacOS that are officially supported. So if you changed the line in the test that uses media.apple.mp3.enabled to instead just check if we're on MacOS, you could also remove that pref. See IsMacOSSnowLeopardOrLater() for an example of how to do that:

https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/dom/media/test/test_can_play_type_mpeg.html#124

Comment 14

[Cervantes Yu [:cyu] [:cervantes]]

(In reply to :Gijs (slow, PTO recovery mode) from comment #9)
> Comment on attachment 8928133 [details] [diff] [review]
> Remove dead accessibility prefs
> 
> Review of attachment 8928133 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: modules/libpref/init/all.js
> @@ -977,5 @@
> >  pref("accessibility.accesskeycausesactivation", true);
> >  pref("accessibility.mouse_focuses_formcontrol", false);
> >  
> >  // Type Ahead Find
> > -pref("accessibility.typeaheadfind", true);
> 
> This is still used, and I don't really understand why you think it is
> unused. It's even synced and has UI. If you're trying to dedupe this with
> browser's firefox.js file, the correct way to do that, IMO, would be to move
> the default value in browser to this file and rm the override in browser (in
> which case it would be courteous to notify fennec/mailnews and/or other
> consumers in case they care about the change in default).

Sorry, it's an error. What I meant to remove is "accessibility.typeaheadfind.enabletimeout" and from the search result https://searchfox.org/mozilla-central/search?q=enabletimeout&case=true&regexp=false&path= it's no longer accessed in our code.

Comment 15

[Cervantes Yu [:cyu] [:cervantes]]

(In reply to Cervantes Yu [:cyu] [:cervantes] from comment #14)
> Sorry, it's an error. What I meant to remove is
> "accessibility.typeaheadfind.enabletimeout" and from the search result
> https://searchfox.org/mozilla-central/
> search?q=enabletimeout&case=true&regexp=false&path= it's no longer accessed
> in our code.

accessibility.typeaheadfind.enabletimeout is still used in comm-central so it's still used. We can move it to suite-relevant pref file.

Comment 16

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead accessibility prefs

Comment 17

[:Gijs (he/him)]

Comment on attachment 8928486 [details] [diff] [review]
Remove dead accessibility prefs

Review of attachment 8928486 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 18

[Bob Owen (:bobowen)]

Comment on attachment 8928134 [details] [diff] [review]
Remove dead prefs for printing

Review of attachment 8928134 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpref/init/all.js
@@ -4295,5 @@
>  pref("helpers.private_mime_types_file", "~/.mime.types");
>  pref("helpers.private_mailcap_file", "~/.mailcap");
>  pref("print.printer_list", ""); // list of printers, separated by spaces
>  pref("print.print_reversed", false);
> -pref("print.print_color", true);

Looks like this (and the one further down) should be print.print_in_color and as a bonus you fix a 15 year old regression (bug 180964). :-)
(Or at least give the correct default pref for people to flip.)

Comment 19

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead prefs for profile management

Comment 20

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Remove dead media prefs

Carryover r+ from :cpearce and jesup.

Update:
- Also remove dead pref "media.mp3.enabled", which was introduced in bug 1214678 for iOS.
- Remove pref "media.apple.mp3.enabled" and update test case accordingly.

Comment 21

[Cervantes Yu [:cyu] [:cervantes]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/804e07186d2c057e5a0f4dc56ee6c4f51c446052
Bug 1416703 - Part 1: Remove dead accessibility prefs in all.js. r=Gijs

https://hg.mozilla.org/integration/mozilla-inbound/rev/a23b36d4dc5563320dbb3b5a3c275832f3cfcad9
Bug 1416703 - Part 2: Remove dead prefs for printing in all.js. r=bobowen

https://hg.mozilla.org/integration/mozilla-inbound/rev/810e5228e5fcc71f570bcc3ff8837c81ffa92c82
Bug 1416703 - Part 3: Remove dead media prefs in all.js. r=cpearce,jesup

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf62d0c0ce5af78eb8a4eb27eaa12c254449912d
Bug 1416703 - Part 4: Remove dead devtools prefs in all.js. r=jdescottes

https://hg.mozilla.org/integration/mozilla-inbound/rev/0821f12ed500027bf4254873a522eac4581f4adb
Bug 1416703 - Part 5: Remove dead prefs for profile management in all.js. r=mak

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9f40d531291a4714c165dd076350a0f04fbdc7a
Bug 1416703 - Part 6: Remove dead gfx prefs in all.js. r=nical

https://hg.mozilla.org/integration/mozilla-inbound/rev/27b171e4cd2d1d51e95df1bfb6fc567500b6284d
Bug 1416703 - Part 7: Remove some dead prefs in all.js. r=baku

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb9c29a3067df17a9fe2d23a541154cccb613018
Bug 1416703 - Part 8: Remove dead security prefs in all.js. r=dveditz

Comment 22

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/804e07186d2c
https://hg.mozilla.org/mozilla-central/rev/a23b36d4dc55
https://hg.mozilla.org/mozilla-central/rev/810e5228e5fc
https://hg.mozilla.org/mozilla-central/rev/cf62d0c0ce5a
https://hg.mozilla.org/mozilla-central/rev/0821f12ed500
https://hg.mozilla.org/mozilla-central/rev/d9f40d531291
https://hg.mozilla.org/mozilla-central/rev/27b171e4cd2d
https://hg.mozilla.org/mozilla-central/rev/eb9c29a3067d