1416754 - SVG animation broken in Nightly 58 and 59

Status: RESOLVED FIXED

(Core :: SVG, defect, P2)

Description

[coastermcgee]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171113100232

Steps to reproduce:

View the following in Firefox 56 and 57 and it works fine.  The same example in Nightly 58 and now 59 has some kind of glitch with the SVG path.  I've tried a fresh profile on both Windows 10 64 bit Nightly and on Mac OS High Sierra and both have the same issue.  This looks like it's a css problem introduced sometime during a Nightly 58 update.

http://bl.ocks.org/brattonc/5e5ce9beee483220e2f6


Actual results:

Glitched out SVG path.


Expected results:

Gauges should look fluid.

Comment 1

[Marcia Knous [:marcia]]

I can confirm this using 20171113100232 (59 nightly) on Mac. Adding relevant keywords to get a regression range.

Comment 2

[Alice0775 White]

I can reproduce the glitch on Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fa3be8644d73a8ef20333924c11b70c5bc034fdf&tochange=ce7f71c2f402beaebf1485323144830e8743fffa

Regressed by: Bug 1382534

@:botond, Your bunch of patch seems to cause the regression. Can you look into this?

Comment 4

[Tobi Reif]

@botond cc

Comment 5

[Botond Ballo [:botond]]

Will investigate.

Comment 6

[Botond Ballo [:botond]]

The testcase is animating the transform of an element inside a clip-path. Rendering is incorrect for a given single frame of the animation, suggesting that the issue is related to the transform itself, and not an invalidation problem related to the transform changing.

Comment 7

[Botond Ballo [:botond]]

Attachment: Testcase (reduced from site)

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().

Review commit: https://reviewboard.mozilla.org/r/200000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200000/

Comment 9

[Botond Ballo [:botond]]

The attached patch fixes the problem for me locally.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=689b6144aba5dc49539c00470457ead08a7c733e

Comment 10

[Botond Ballo [:botond]]

Attachment: Bug 1416754 - Reftest.

Review commit: https://reviewboard.mozilla.org/r/200860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200860/

Comment 11

[Robert Longson [:longsonr]]

Comment on attachment 8929590 [details]
Bug 1416754 - Reftest.

https://reviewboard.mozilla.org/r/200860/#review206128

Comment 12

[Robert Longson [:longsonr]]

Comment on attachment 8928730 [details]
Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().

https://reviewboard.mozilla.org/r/200000/#review206130

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74f295778860
Account for a clip-path's transform in nsSVGUtils::GetBBox(). r=longsonr
https://hg.mozilla.org/integration/autoland/rev/9ac3ceb81b01
Reftest. r=longsonr

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/74f295778860
https://hg.mozilla.org/mozilla-central/rev/9ac3ceb81b01

Comment 15

[Astley Chen (inactive)]

Please help to create uplift request for 58 beta. Thanks.

Comment 16

[Botond Ballo [:botond]]

Comment on attachment 8928730 [details]
Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().

Approval Request Comment
[Feature/Bug causing the regression]:
  Bug 1382534

[User impact if declined]:
  SVG images (could be static images or animations)
  involving a clip-path with a transform are rendered
  incorrectly.

[Is this code covered by automated tests?]:
  Yes

[Has the fix been verified in Nightly?]:
  Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
  No

[List of other uplifts needed for the feature/fix]:
  None

[Is the change risky?]:
  No

[Why is the change risky/not risky?]:
  It's a straightforward, one line change

[String changes made/needed]:
  None

Comment 17

[Botond Ballo [:botond]]

Comment on attachment 8929590 [details]
Bug 1416754 - Reftest.

(See previous comment)

Comment 18

[Gerry Chang [:gchang]]

Comment on attachment 8928730 [details]
Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().

Fix a SVG animation regression. Beta58+.

Comment 19

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/847de4bb6c76