Closed Bug 1416766 Opened 5 years ago Closed 5 years ago

wasm: fix i64 throwing behavior for globals / imported/exported functions

Categories

(Core :: JavaScript Engine: JIT, enhancement)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(2 files)

1.globals.patch
11.37 KB, patch
luke
: review+
Details | Diff | Splinter Review
2.functions.patch
9.85 KB, patch
luke
: review+
Details | Diff | Splinter Review 
No description provided.
Attached patch 1.globals.patch — — Splinter Review
Attachment #8927848 - Flags: review?(luke)
Comment on attachment 8927848 [details] [diff] [review]
1.globals.patch

Review of attachment 8927848 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8927848 - Flags: review?(luke) → review+
Comment on attachment 8927849 [details] [diff] [review]
2.functions.patch

Review of attachment 8927849 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8927849 - Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91858a00db91
Int64 wasm globals should cause a link failure at instanciation time, not compile time; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/75c9879941ee
Immediately throw if an exported wasm function has int64 in the signature; r=luke
https://hg.mozilla.org/mozilla-central/rev/91858a00db91
https://hg.mozilla.org/mozilla-central/rev/75c9879941ee
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Won't fix for 58, let it ride the train.
status-firefox58: affected → wontfix
You need to log in before you can comment on or make changes to this bug.