1416766 - wasm: fix i64 throwing behavior for globals / imported/exported functions

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 1.globals.patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: 2.functions.patch

https://github.com/WebAssembly/design/issues/1152
https://github.com/WebAssembly/design/pull/1154

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 8927848 [details] [diff] [review]
1.globals.patch

Review of attachment 8927848 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Luke Wagner [:luke]]

Comment on attachment 8927849 [details] [diff] [review]
2.functions.patch

Review of attachment 8927849 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91858a00db91
Int64 wasm globals should cause a link failure at instanciation time, not compile time; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/75c9879941ee
Immediately throw if an exported wasm function has int64 in the signature; r=luke

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/91858a00db91
https://hg.mozilla.org/mozilla-central/rev/75c9879941ee

Comment 7

[Gerry Chang [:gchang]]

Won't fix for 58, let it ride the train.