Closed
Bug 1416766
Opened 8 years ago
Closed 8 years ago
wasm: fix i64 throwing behavior for globals / imported/exported functions
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(2 files)
11.37 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
9.85 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8927848 -
Flags: review?(luke)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8927849 -
Flags: review?(luke)
![]() |
||
Comment 3•8 years ago
|
||
Comment on attachment 8927848 [details] [diff] [review]
1.globals.patch
Review of attachment 8927848 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8927848 -
Flags: review?(luke) → review+
![]() |
||
Comment 4•8 years ago
|
||
Comment on attachment 8927849 [details] [diff] [review]
2.functions.patch
Review of attachment 8927849 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8927849 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91858a00db91
Int64 wasm globals should cause a link failure at instanciation time, not compile time; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/75c9879941ee
Immediately throw if an exported wasm function has int64 in the signature; r=luke
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/91858a00db91
https://hg.mozilla.org/mozilla-central/rev/75c9879941ee
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment 7•8 years ago
|
||
Won't fix for 58, let it ride the train.
You need to log in
before you can comment on or make changes to this bug.
Description
•