1416775 - Don't show "Bookmark This Page" for bookmarks in the remote Mobile Bookmarks folder

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Simon Basca [:SimonB]]

Build: 10.1(7709) 
Device: iPhone 8 Plus
iOS: 11.1

Pre - requisites:
- Sign in to FxA 

Steps to reproduce:
1. Go to google.com
2. Open the page action menu and tap "Bookmark this Page"
3. Go to Settings and tap "Sync Now"
4. Go to the Bookmark panel
5. Tap on the bookmarked page (the google.com page)
6. Open the Page Action menu and check the bookmark button

Actual results:
- The bookmarked state is not reflected in the Page Action menu. If you tap on the "Bookmark this Page" button, the bookmark can be duplicated. 

Expected results: 
- Local and synced bookmarks should appear as bookmarked in the Page Action menu.

Comment 1

[Richard Newman [:rnewman]]

I think I can rephrase this as "isBookmarked doesn't check the buffer".

This is a side-effect of the hacky mobile bookmark uploader.

There's a difficulty here: a bookmark can actually be in several states.

- It's not bookmarked anywhere.
- It's bookmarked and I can remove the bookmark (it's local, or it's in a folder that I'm allowed to delete from).
- It's bookmarked and I can't.

`isBookmarked` isn't enough to represent this; it's used to decide whether to show "Bookmark This Page" or "Remove Bookmark", and of course we need a third state or a second boolean.

I suggest rotating this concept a little: the boolean that controls that should be whether the page is in the local or remote Mobile Bookmarks folder, which aligns with the actions we can take. Then make a separate flag that controls whether we show the star in the URL bar results, which is whether the page is bookmarked anywhere.