1416836 - browser.browserSettings.homepageOverride.get() does not work if extension does not override the homepage

Status: RESOLVED DUPLICATE of bug 1408099

(WebExtensions :: General, defect)

Description

[Andrew Swan [:aswan]]

In bug 1322308 we added browser.browserSettings.homepageOverride to let extensions read the current value of the homepage.  The implementation tries to read the "homepage_override" key from the extension settings manager, but this key is never registered with the settings manager if an extension doesn't include a homepage override in its manifest.  This leads to an internal error with something like this at the top of the stack:
settingsMap.get(...) is undefined  ExtensionPreferencesManager.jsm:358

I haven't looked closely but I suspect we probably have a similar issue with newtab.

Comment 1

[Kris Maglione [:kmag]]

[Tracking Requested - why for this release]: This feature was added in 57 and the failure causes add-on breakage in current users of 58.

Comment 2

[Bob Silverberg [:bsilverberg]]

This is odd, as I would have thought this was fixed via bug 1408099, which landed in 58. I'll investigate further.

Comment 3

[Bob Silverberg [:bsilverberg]]

I just verified that this is indeed fixed in 58. I am guessing that the reporter (who communicated this bug via email) was using Beta = 57 when this was discovered. It's a known bug in 57, but was fixed in 58.

Comment 4

[Gerry Chang [:gchang]]

Mark 58 fixed as bug 1408099 was fixed in 58.