1416903 - stylo: OOM crash in core::result::unwrap_failed<T> | style::selector_map::MaybeCaseInsensitiveHashMap<T>::entry<T>

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-49ef3f7d-0912-429a-97c0-978350171112.
=============================================================

Seen while looking at crash stats: http://bit.ly/2ie1tCI. Crash reason: called `Result::unwrap()` on an `Err` value: FailedAllocationError { reason: "out of memory when allocating RawTable" }

Affects 57 and 58.

Top 10 frames of crashing thread:

0 xul.dll std::panicking::rust_panic_with_hook src/libstd/panicking.rs:617
1 xul.dll std::panicking::begin_panic<alloc::string::String> src/libstd/panicking.rs:572
2 xul.dll std::panicking::begin_panic_fmt src/libstd/panicking.rs:522
3 xul.dll core::panicking::panic_fmt src/libcore/panicking.rs:70
4 xul.dll core::result::unwrap_failed<hashglobe::FailedAllocationError> src/libcore/macros.rs:41
5 xul.dll style::selector_map::MaybeCaseInsensitiveHashMap<style::gecko_string_cache::Atom, smallvec::SmallVec<[style::invalidation::element::invalidation_map::Dependency; 1]>>::entry<smallvec::SmallVec<[style::invalidation::element::invalidation_map::Dependency; 1]>> servo/components/style/selector_map.rs:481
6 xul.dll style::stylist::CascadeData::add_stylesheet<style::gecko::data::GeckoStyleSheet> servo/components/style/stylist.rs:2055
7 xul.dll geckoservo::glue::Servo_StyleSet_FlushStyleSheets servo/ports/geckolib/glue.rs:1184
8 xul.dll mozilla::ServoStyleSet::UpdateStylist layout/style/ServoStyleSet.cpp:1476
9 xul.dll nsIDocument::FlushUserFontSet dom/base/nsDocument.cpp:13605

=============================================================

Comment 1

[Chris Peterson [:cpeterson]]

I'm reducing this bug's priority from P2 to P3 because this is a low volume OOM crash.

Comment 2

[[:philipp]]

this crash is strongly correlated to the presence of adblock plus:
(83.20% in signature vs 13.62% overall) Addon "Adblock Plus" = true

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to [:philipp] from comment #2)
> this crash is strongly correlated to the presence of adblock plus:
> (83.20% in signature vs 13.62% overall) Addon "Adblock Plus" = true

That makes sense off-hand, since Adblock injects a lot of style rules in the page. Maybe they're injecting too many, or using a pattern that makes us use a lot of memory?

Comment 4

[Chris Peterson [:cpeterson]]

Curiously, 99.95% of the 3674 MaybeCaseInsensitiveHashMap crash reports from the last six months are from Windows. Just 2 crash reports where from Linux.

Comment 5

[Marcia Knous [:marcia]]

Looks as if the 2nd signature is cropping up again on nightly 63 and 64 - https://bit.ly/2Qn2Kaf. And the signature I just added in 62.

Comment 6

[Hani Yacoub, Desktop QA]

Closing this as resolved:worksforme since there were no crashes in the last 6 months for this signature.