Closed
Bug 1417038
Opened 7 years ago
Closed 7 years ago
Shrink ExitFooterFrame to 1 word
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files, 1 obsolete file)
|
5.35 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
|
29.20 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Instead of storing both JitCode* and VMFunction* we can now store 1 pointer that's either the ExitFrameToken or VMFunction*.
|
Assignee | |
Comment 1•7 years ago
|
||
Dead code since the Ion IC rewrite.
Attachment #8928146 -
Flags: review?(nicolas.b.pierron)
|
|
Assignee | |
Comment 2•7 years ago
|
||
ExitFooterFrame now stores either the VMFunction* or the ExitFrameType. I renamed ExitFrameToken to ExitFrameType because it's a better name now (ExitFrameType also contains VMFunction).
Attachment #8928147 -
Flags: review?(nicolas.b.pierron)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8928147 -
Attachment is obsolete: true
Attachment #8928147 -
Flags: review?(nicolas.b.pierron)
Attachment #8928148 -
Flags: review?(nicolas.b.pierron)
|
||
Updated•7 years ago
|
Attachment #8928146 -
Flags: review?(nicolas.b.pierron) → review+
|
|
||
Updated•7 years ago
|
Attachment #8928148 -
Flags: review?(nicolas.b.pierron) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c2e4e6d7886e part 1 - Remove unused IonOOLPropertyOpExitFrameLayout and IonOOLSetterOpExitFrameLayout. r=nbp https://hg.mozilla.org/integration/mozilla-inbound/rev/0b10cf1da7f2 part 2 - Shrink ExitFooterFrame to one word. r=nbp
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c2e4e6d7886e https://hg.mozilla.org/mozilla-central/rev/0b10cf1da7f2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•