141717 - function getSelection() breaks context menus

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

If a page tries to write its own |function getSelection()| context menus will
break since it uses getSelection for the "Search engine" context menu item.

Mozilla should either prevent users over-writing this, or not break context
menus.  See also bug 141716 for fixing Bugzilla to not use that method.

Comment 1

[Johnny Stenback (:jst)]

There's nothing that can be done about this in the DOM, the code that deals with
the context menus can work around this to be certain (or more so at least)
they're calling the right method. The "right" getSelection() method can be found
on the window object's prototype even if a webpage defines its own function
named getSelection. To do this, the context menu code can do something like this
(not exactly clean, but we don't have much better options here):

  window.__proto__.getSelection.call(window);

Comment 2

[Jesse Ruderman]

jst's workaround might be useful for other chrome javascript that interacts with
the page's window object.  See bug 36946 (still security-sensitive!?) for
related discussion.

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch v.1.0

Yeah this works I guess.  Also fixes a problem where we reference an undefined 
property (this.onMetaDataItem).

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

->Me.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 90364 [details] [diff] [review]
Patch v.1.0

r=biesi

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 90364 [details] [diff] [review]
Patch v.1.0

sr=jst

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in.