1417175 - npm-shrinkwrap.json is generated differently depending on the npm version

Status: RESOLVED WORKSFORME

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Mark Banner (:standard8)]

When I did the latest update to ESLint, I generated npm-shrinkwrap from npm version 5.5.1. If it is generated from pre-5.4.0, then there are differences.

STR

1) rm -r node_modules
2) npm install -g npm@<version>

(replace <version> with the version under test).

3) npm install
4) git diff

Results

-> If using pre-5.4.0, then the location of "string_decoder" is different within the file.
-> If using 5.4.0 or later, then there are no differences.

Comment 1

[Mark Banner (:standard8)]

I'm not sure there's much we can do here, except encourage developers to upgrade to newer versions. We could bump the minimum npm version in setup_helper.py, but I'm not sure we want to do that this soon - these are fairly recent releases.

On the plus side, brew is shipping 5.5.1, as is the latest version of MozillaBuild.

Comment 3

[Mark Banner (:standard8)]

Since we landed the bump to 5.5.1 as the minimum version, this is a lot better now. There's still bug 1465164 at issue, so there's a potential minor issue with npm itself, but I think we can close this one out for now.