1417185 - Reintroduce a way to make ConsoleService shut up

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Honza Bambas (:mayhemer)]

Bug 1414150 removed consoleservice.enabled pref that was a (relatively) convenient way to disable debug output of JS console to VS output window.  It otherwise renders using tracepoints in VS impossible because of all the flood.

No idea why that pref has been removed.  There has to be some way except hacking the code to disable this, preferably with an env var or at least with reintroduction of that or some other pref.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

this is the most convenient solution for me.  set the env var in my run-in-debugger env (visual studio) and be independent of a profile I run at, since I often delete the whole profile dir to start over which looses the preferences.

by default the behavior is identical as before the patch when nothing is specified.  the env var only disables the OutputDebugString part on windows, nothing else.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8942699 [details] [diff] [review]
v1

Review of attachment 8942699 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsConsoleService.cpp
@@ +53,5 @@
>  NS_IMPL_CI_INTERFACE_GETTER(nsConsoleService, nsIConsoleService, nsIObserver)
>  
>  static const bool gLoggingEnabled = true;
>  static const bool gLoggingBuffered = true;
> +static bool gLoggingToDebugger = true;

I would enclose this in `#ifdef XP_WIN` to make it clear it's Windows only.

@@ +80,5 @@
> +  // To disable OutputDebugString set:
> +  //   MOZ_CONSOLESERVICE_DISABLE_DEBUGGER_OUTPUT=1
> +  //
> +  const char* disableDebugLoggingVar = getenv("MOZ_CONSOLESERVICE_DISABLE_DEBUGGER_OUTPUT");
> +  gLoggingToDebugger = !disableDebugLoggingVar || (disableDebugLoggingVar[0] == '1');

I think you want `!= '1'`

Comment 3

[Honza Bambas (:mayhemer)]

(In reply to Jim Chen [:jchen] [:darchons] from comment #2)
> I would enclose this in `#ifdef XP_WIN` to make it clear it's Windows only.

had the same idea, yes.

> > +  gLoggingToDebugger = !disableDebugLoggingVar || (disableDebugLoggingVar[0] == '1');
> 
> I think you want `!= '1'`

yes!  I reversed the logic at the end (originally had _ENABLE_ var) and left this unfixed, good catch, thanks!

Comment 4

[Honza Bambas (:mayhemer)]

Attachment: v1.1

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: v1.1

(correct reviewer in cm)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f3711534710
Introduce MOZ_CONSOLESERVICE_DISABLE_DEBUGGER_OUTPUT env var to prevent nsConsoleService from flooding debugger's output window, r=jchen

Comment 7

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/1f3711534710