1417320 - ReturnInParagraph should have Element parameter instead of nsINode

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1417320 - ReturnInParagraph should have Element parameter instead of nsINode.

ReturnInListItem and ReturnInHeader uses Element as parameter, but
ReturnInParagraph doesn't use Element parameter even if it is Element.

So we should use Element for parameter.

Review commit: https://reviewboard.mozilla.org/r/199650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199650/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8928422 [details]
Bug 1417320 - ReturnInParagraph should have Element parameter instead of nsINode.

https://reviewboard.mozilla.org/r/199650/#review204744

::: editor/libeditor/HTMLEditRules.h:324
(Diff revision 1)
> -  nsresult SplitParagraph(nsIDOMNode* aPara,
> +  nsresult SplitParagraph(Element& aPara,
>                            nsIContent* aBRNode,
> -                          Selection* aSelection,
> +                          Selection& aSelection,

I like make wider object like Selection first in argument list, but up to you because anyway, we need to make this method use EditorRawDOMPoint later.

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8928422 [details]
Bug 1417320 - ReturnInParagraph should have Element parameter instead of nsINode.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199650/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f139f5b4ee78
ReturnInParagraph should have Element parameter instead of nsINode. r=masayuki

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f139f5b4ee78