1417336 - [Form Autofill] Enable credit card autofill by default on beta build

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Luke Chang [:lchang] (inactive)]

We are going to test Credit Card Autofill on Fx58 beta 5. Let's enable it by default.

Note that the feature is still restricted to the users who use en-US build and are located in the US.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1417336 - [Form Autofill] Enable credit card autofill by default on beta build.

Review commit: https://reviewboard.mozilla.org/r/199696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199696/

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 8928441 [details]
Bug 1417336 - [Form Autofill] Enable credit card autofill by default on beta build.

https://reviewboard.mozilla.org/r/199696/#review205722

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a6366334926
[Form Autofill] Enable credit card autofill by default on beta build. r=steveck

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0a6366334926

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8928441 [details]
Bug 1417336 - [Form Autofill] Enable credit card autofill by default on beta build.

Approval Request Comment
[Feature/Bug causing the regression]:
Feature: Credit Card Autofill. We'd like to enable it on Fx58 beta 5 for testing.

[User impact if declined]:
Beta users won't see the feature.

[Is this code covered by automated tests?]:
Not necessary. It only flipped a pref.

[Has the fix been verified in Nightly?]:
No since it doesn't actually affect nightly.

[Needs manual test from QE? If yes, steps to reproduce]:
Yes. Steps on beta:

0. Change the pref "extensions.formautofill.available" to "on" via "about:config" if you're neither using en-US build nor located in the US.

1. Open Preferences and go to "Privacy & Security" panel.
2. Check if "Autofill Credit Card" exists under "Forms & Passwords" section.

[List of other uplifts needed for the feature/fix]:
N/A

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It just changed the default value of the pref "extensions.formautofill.creditCards.available" on the beta build.

[String changes made/needed]:
N/A

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8928441 [details]
Bug 1417336 - [Form Autofill] Enable credit card autofill by default on beta build.

Enable credit card form autofill in Beta58. Beta58+.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1ec9ad9a1be2

Comment 8

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with 59.0a1 and 580b5, the pref extensions.formautofill.creditCards.available is set by default to "true", saved credit cards are available under Preferences on beta after extensions.formautofill.available pref is set to "on". 

Verified on Ubuntu 14.4, WIndows 10x64 and MacOS 10.12.6