Closed Bug 1417368 Opened 2 years ago Closed 2 years ago

Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning

Categories

(DevTools :: Netmonitor, defect, P2)

defect

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Launchpad is broken by regression from bug 1404917. It throws `TypeError: response is undefined` on console. On the other hand, there is an Toolbox.shouldComponentUpdate warning on console as well.
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Comment on attachment 8928463 [details]
Bug 1417368 - Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning

https://reviewboard.mozilla.org/r/199714/#review204828

Looks reasonable to me
R+ assumin try is green

Thanks Ricky for fixing this!
Honza
Attachment #8928463 - Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/432b91c9ad95
Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning r=Honza
https://hg.mozilla.org/mozilla-central/rev/432b91c9ad95
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.