1417383 - Move tests directly under docshell/tests into sub-directories to aid ESLint

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P3)

Description

[Mark Banner (:standard8)]

Currently we have tests directly under docshell/tests, as well as within sub-directories of it.

I'm guessing the sub-directories were added for different types of tests.

From an ESLint perspective, managing this is really difficult - applying rules/globals to the docshell/tests directory, will also apply to the sub-directories, which may allow accidental use of globals or other items that aren't allowed, degrading the developer experience.

I think the tests directly under that directory should be moved into docshell/tests/mochitest.

Comment 1

[Andrew Overholt [:overholt]]

I have a patch for this and will get back to it later this week (hopefully).

Comment 2

[Mark Banner (:standard8)]

Andrew, do you still have a patch for this, or would it need regenerating?

Comment 3

[Andrew Overholt [:overholt]]

It needs regenerating (and I don't have it handy). I won't have time this week, unfortunately. qDot is working in docshell these days, maybe he has a second to do this?

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Yeah I can do it.

Comment 5

[Mark Banner (:standard8)]

qDot has agreed that I can take this over, I should be able to find time sometime later this week.

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1417383 - Remove unused test files that were missed in bug 1427726.

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1417383 - Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint.

Depends on D7052

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 1417383 - Add initial .eslintrc.js files for docshell test directories (not enabled yet).

Depends on D7053

Comment 9

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ab9a1f3fc87248b00526fc46ec422e873a6891e

Comment 10

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 9012522 [details]
Bug 1417383 - Add initial .eslintrc.js files for docshell test directories (not enabled yet).

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 9012520 [details]
Bug 1417383 - Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint.

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.

Comment 12

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 9012519 [details]
Bug 1417383 - Remove unused test files that were missed in bug 1427726.

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddaef0a8de5f
Remove unused test files that were missed in bug 1427726. r=qdot
https://hg.mozilla.org/integration/autoland/rev/d0d9cd85f3db
Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint. r=qdot
https://hg.mozilla.org/integration/autoland/rev/44d07650e6fe
Add initial .eslintrc.js files for docshell test directories (not enabled yet). r=qdot

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88315c6735de
Backed out 3 changesets for bustages in /builds/worker/workspace/build/src/docshell/test/mochitest/moz.build CLOSED TREE

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3269d08cf46
Remove unused test files that were missed in bug 1427726. r=qdot
https://hg.mozilla.org/integration/autoland/rev/3367b2fb2771
Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint. r=qdot
https://hg.mozilla.org/integration/autoland/rev/cd7aa09c2b62
Add initial .eslintrc.js files for docshell test directories (not enabled yet). r=qdot

Comment 16

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a3269d08cf46
https://hg.mozilla.org/mozilla-central/rev/3367b2fb2771
https://hg.mozilla.org/mozilla-central/rev/cd7aa09c2b62