Closed Bug 1417383 Opened 2 years ago Closed Last year

Move tests directly under docshell/tests into sub-directories to aid ESLint

Categories

(Core :: Document Navigation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Currently we have tests directly under docshell/tests, as well as within sub-directories of it.

I'm guessing the sub-directories were added for different types of tests.

From an ESLint perspective, managing this is really difficult - applying rules/globals to the docshell/tests directory, will also apply to the sub-directories, which may allow accidental use of globals or other items that aren't allowed, degrading the developer experience.

I think the tests directly under that directory should be moved into docshell/tests/mochitest.
Blocks: 1357557
Priority: -- → P3
I have a patch for this and will get back to it later this week (hopefully).
Assignee: nobody → overholt
Andrew, do you still have a patch for this, or would it need regenerating?
Flags: needinfo?(overholt)
It needs regenerating (and I don't have it handy). I won't have time this week, unfortunately. qDot is working in docshell these days, maybe he has a second to do this?
Assignee: overholt → nobody
Flags: needinfo?(overholt) → needinfo?(kyle)
Yeah I can do it.
Assignee: nobody → kyle
Flags: needinfo?(kyle)
qDot has agreed that I can take this over, I should be able to find time sometime later this week.
Assignee: kyle → standard8
Comment on attachment 9012522 [details]
Bug 1417383 - Add initial .eslintrc.js files for docshell test directories (not enabled yet).

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.
Attachment #9012522 - Flags: review+
Comment on attachment 9012520 [details]
Bug 1417383 - Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint.

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.
Attachment #9012520 - Flags: review+
Comment on attachment 9012519 [details]
Bug 1417383 - Remove unused test files that were missed in bug 1427726.

Kyle Machulis [:qdot] [:kmachulis] (if a patch has no decent commit message, automatic r-) has approved the revision.
Attachment #9012519 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddaef0a8de5f
Remove unused test files that were missed in bug 1427726. r=qdot
https://hg.mozilla.org/integration/autoland/rev/d0d9cd85f3db
Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint. r=qdot
https://hg.mozilla.org/integration/autoland/rev/44d07650e6fe
Add initial .eslintrc.js files for docshell test directories (not enabled yet). r=qdot
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88315c6735de
Backed out 3 changesets for bustages in /builds/worker/workspace/build/src/docshell/test/mochitest/moz.build CLOSED TREE
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3269d08cf46
Remove unused test files that were missed in bug 1427726. r=qdot
https://hg.mozilla.org/integration/autoland/rev/3367b2fb2771
Move mochitests from docshell/test/ to docshell/test/mochitest/ to aid ESLint. r=qdot
https://hg.mozilla.org/integration/autoland/rev/cd7aa09c2b62
Add initial .eslintrc.js files for docshell test directories (not enabled yet). r=qdot
QA Contact: kyle
QA Contact: kyle
You need to log in before you can comment on or make changes to this bug.