Closed
Bug 1417708
Opened 7 years ago
Closed 7 years ago
Remove unused 'wraparound' attribute on numberbox binding
Categories
(Core :: XUL, task, P5)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
Source: https://dxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/numberbox.xml#62
I don't see any usages of this in m-c or c-c except for a test:
https://dxr.mozilla.org/mozilla-central/source/toolkit/content/tests/chrome/test_textbox_number.xul?q=wraparound%3D&redirect_type=single#14
https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/content/tests/chrome/test_textbox_number.xul?q=wraparound%3D&redirect_type=single#14
I think the property, any conditions in the XML, and the test assertions about 'n2' can be removed.
|
Assignee | |
Comment 1•7 years ago
|
||
Something else to look into: use <html:input type="number" /> and get rid of the spinbuttons altogether since the HTML form control will render them
|
|
Assignee | |
Updated•7 years ago
|
Summary: Remove unused 'wraparound' attribute on numberbox binding → Remove unused 'wraparound' and 'decimalplaces' attributes on numberbox binding
|
|
Assignee | |
Updated•7 years ago
|
Summary: Remove unused 'wraparound' and 'decimalplaces' attributes on numberbox binding → Remove unused 'wraparound' attribute on numberbox binding
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → wontfix
status-firefox59:
--- → fix-optional
Priority: -- → P5
|
|
||
Updated•7 years ago
|
Attachment #8929534 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Neil, I think the r+ somehow didn't get copied over to mozreview which is preventing autoland from landing it. Not sure why - but would you be able to r+ in that UI as well? https://reviewboard.mozilla.org/r/200812/diff/2.
Flags: needinfo?(enndeakin)
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8929534 [details]
Bug 1417708 - Remove unused wraparound attribute from numberbox;+6102
https://reviewboard.mozilla.org/r/200812/#review210632
|
||
Comment 7•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s b399e19009d0 -d 58fec9a96e26: rebasing 437237:b399e19009d0 "Bug 1417708 - Remove unused wraparound attribute from numberbox;r=enndeakin+6102+6102" (tip)
merging toolkit/content/widgets/numberbox.xml
warning: conflicts while merging toolkit/content/widgets/numberbox.xml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
|
|
||
Updated•7 years ago
|
Flags: needinfo?(enndeakin)
| Comment hidden (mozreview-request) |
|
|
||
Comment 9•7 years ago
|
||
hg error in cmd: hg update --clean -r 53633488f984: abort: unknown revision '53633488f984'!
| Comment hidden (mozreview-request) |
|
||
Comment 11•7 years ago
|
||
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/896c4331a662
Remove unused wraparound attribute from numberbox;r=enndeakin+6102+6102
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Comment 13•7 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•