Closed
Bug 1417711
Opened 7 years ago
Closed 7 years ago
[css-grid] An abs.pos. child that only covers removed 'auto-fit' tracks stretches to the end padding edge
Categories
(Core :: Layout, defect, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: testcase)
Attachments
(3 files)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce942246e1c95cacbe1c72defd05437f76afa7a5
Attachment #8928998 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 2•7 years ago
|
||
BTW, this patch makes us compatible with Chrome for the reftests in the patch, except for the Chrome bug I filed here: https://bugs.chromium.org/p/chromium/issues/detail?id=785626
|
||
Comment 3•7 years ago
|
||
Here's an additional testcase that shows there are still some cases where absolute position children get incorrectly stretched.
|
|
Assignee | |
Comment 4•7 years ago
|
||
It looks correct to me at first glance. The abs.pos. has 'grid-column: 5' which means 'grid-column-end' is 'auto', which for abs.pos. means "the virtual line at the CB edge" (unlike for normal flow grid items where 'auto' means 'span 1'). See the paragraph about "augmented grid": https://drafts.csswg.org/css-grid/#augmented-grid So to test abs.pos. children you need to write out the end value explicitly using a line number or span.
|
||
Comment 5•7 years ago
|
||
Comment on attachment 8928998 [details] [diff] [review] An abs.pos. grid container child that only covers removed 'auto-fit' tracks should not span to the end padding edge Review of attachment 8928998 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay! Back from vacation now. :) r=me, one nit: ::: layout/reftests/css-grid/grid-repeat-auto-fill-fit-012-ref.html @@ +4,5 @@ > + http://creativecommons.org/publicdomain/zero/1.0/ > +--> > +<html><head> > + <meta charset="utf-8"> > + <title>CSS Grid Test: repeat(auto-fit) with removed tracks</title> s/CSS Grid Test/Reference/ (for consistency with your other reference cases in this directory, e.g. https://dxr.mozilla.org/mozilla-central/rev/da90245d47b17c750560dedb5cbe1973181166e3/layout/reftests/css-grid/grid-repeat-auto-fill-fit-001-ref.html )
Attachment #8928998 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/502cd76b6f82 [css-grid] An abs.pos. grid container child that only covers removed 'auto-fit' tracks should not span to the end padding edge. r=dholbert
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/502cd76b6f82
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
|
Assignee | |
Updated•7 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•