1417731 - missing fennec r-d emails

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Aki Sasaki (not active)]

Attachment: fix-fennec-notifications

This patch adds the missing routes to the release-notify-{promote,publish} kinds.

On beta, we get

(promote):
index.releases.v1.mozilla-beta.196059cada7070ab1e35db83a22b60389bd0c794.fennec.58_0b4.build1.email-beta-candidates
index.releases.v1.mozilla-beta.latest.fennec.latest.email-beta-candidates

(publish):
index.releases.v1.mozilla-beta.196059cada7070ab1e35db83a22b60389bd0c794.fennec.58_0b4.build1.email-beta
index.releases.v1.mozilla-beta.latest.fennec.latest.email-beta

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 8928775 [details] [diff] [review]
fix-fennec-notifications

Review of attachment 8928775 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for addressing this. Callek was asking about this yesterday. :)

Comment 2

[Aki Sasaki (not active)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0fad48717ca1

Waiting for inbound to open.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/062e2a74416a
fix fennec email notifications. r=rail a=release

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/062e2a74416a

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

We're getting mail now, with subjects like 
  mozilla-beta 58.0b9 build1 is in the candidates directory

Can we squeeze a Fennec in there ? Maybe via product in https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/release-notify-promote/kind.yml#36 ?

Comment 6

[Rok Garbas [:garbas]]

:nthomas This will be fixed with next merge of maple which should happen this week. 

Ofcourse we can also do a quick fix in the link you provided above.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Do you mean switching to tc notifications ? Will we uplift that to 58 ? I'm guessing no, but a fix here is only nice to have given everything else going on.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

https://hg.mozilla.org/projects/maple/rev/e60ed99c0c3e but without the release-notify-ship part, I guess.

Comment 9

[Rok Garbas [:garbas]]

:nthomas no, just formatting of notification messages is fixed. aha I also see you found the commit.

While we are talking about this here maybe it is the best place to get feedback around notification messages. Would it make sense to add "project" (aka branch) to other development branches. Let me explain with the example:

Currently messages for all projects (aka branches) will be:

   "fennec 58.b10 build2 is in the candidates directory"

Emails will be send to different emails, but for people that are on subscribed on all of this mailing lists it will be confusing, i think.

My proposal is to keep the message the same for "mozilla-beta" and "mozilla-release" projects (aka branches), but for others we would add a project in the subject/message.

Example for try:

    "[try] fennec 58.b10 build2 is in the candidates directory"

How do you feel for the above proposal?

Comment 10

[Aki Sasaki (not active)]

SGTM :)

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

I like that idea too.