1417824 - stylo: both "Open with" and "Save File" radio buttons on file save dialog are highlighed on Mac

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: radio-button-screenshot.png

STR:
1. Enable stylo-chrome on macOS
2. Open page https://www.iconfinder.com/icons/1760338/biscuit_chips_cookie_food_snack_icon#size=48
3. In the "Opening" file dialog, confirm that the "Save File" radio button is selected and highlighted, as expeced.
4. Click the "Open with" radio button.

RESULT:
Both the "Open with" and "Save File" radio buttons are highlighted, but only one should be. See the attached screenshot: radio-button-screenshot.png.

After selecting the "Open with" radio button, if you click the OK button without choosing the "Open with" application, the dialog will show an "Application not found" warning and its OK button will be truncated. See the attached screenshot: ok-button-screenshot.png. I don't know if this is a duplicate of bug 1417220 or a separate issue.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: ok-button-screenshot.png

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Looks like it isn't reproducible on Windows...

Comment 3

[Chris Peterson [:cpeterson]]

The truncated OK button (comment 1 screenshot) is fixed in Nightly 59.0a1 build 2017-11-18, but I can still reproduce the multiple radio button highlights (comment 0 screenshot and STR).

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

I can reproduce this on macOS. My guess is that the other radio button is not restyled correctly...

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

FWIW, it seems to me that when I hover the other radio button, the button is then correctly restyled to non-selected state.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

So it might be some invalidation issue.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

So the related code is: https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/layout/base/GeckoRestyleManager.cpp#412-424

We may need to port some other code to ServoRestyleManager as well... It isn't currently clear what other stuff would affect.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1417824 part 1 - Query theme for attribute change on element with appearance.

The change is mostly copied from GeckoRestyleManager::AttributeChanged.
It is not clear to me whether it's worth moving it to the superclass so
that we don't duplicate the code. If we are removing the Gecko code in
short term, it probably doesn't matter.

It is also not clear whether we should port other code from that method
to ServoRestyleManager.

Review commit: https://reviewboard.mozilla.org/r/202210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202210/

Comment 9

[Cameron McCormack (:heycam)]

Comment on attachment 8931130 [details]
Bug 1417824 part 1 - Query theme for attribute change on element with appearance.

https://reviewboard.mozilla.org/r/202210/#review207958

Is it worth making a reftest for this?

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1417824 part 2 - Add reftest for this bug.

Review commit: https://reviewboard.mozilla.org/r/202938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202938/

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8931130 [details]
Bug 1417824 part 1 - Query theme for attribute change on element with appearance.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202210/diff/1-2/

Comment 12

[Cameron McCormack (:heycam)]

Comment on attachment 8931815 [details]
Bug 1417824 part 2 - Add reftest for this bug.

https://reviewboard.mozilla.org/r/202938/#review208270

Great, thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0c7f8a95402
part 1 - Query theme for attribute change on element with appearance. r=heycam
https://hg.mozilla.org/integration/autoland/rev/890ae45c3d15
part 2 - Add reftest for this bug. r=heycam

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d0c7f8a95402
https://hg.mozilla.org/mozilla-central/rev/890ae45c3d15

Comment 15

[Chris Peterson [:cpeterson]]

Verified fixed in Nightly 59.0a1 (2017-11-27).