stylo: both "Open with" and "Save File" radio buttons on file save dialog are highlighed on Mac

VERIFIED FIXED in Firefox 59

Status

()

Core
CSS Parsing and Computation
P2
normal
VERIFIED FIXED
2 months ago
2 months ago

People

(Reporter: cpeterson, Assigned: xidorn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla59
Unspecified
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 unaffected, firefox59 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Reporter)

Description

2 months ago
Created attachment 8928899 [details]
radio-button-screenshot.png

STR:
1. Enable stylo-chrome on macOS
2. Open page https://www.iconfinder.com/icons/1760338/biscuit_chips_cookie_food_snack_icon#size=48
3. In the "Opening" file dialog, confirm that the "Save File" radio button is selected and highlighted, as expeced.
4. Click the "Open with" radio button.

RESULT:
Both the "Open with" and "Save File" radio buttons are highlighted, but only one should be. See the attached screenshot: radio-button-screenshot.png.

After selecting the "Open with" radio button, if you click the OK button without choosing the "Open with" application, the dialog will show an "Application not found" warning and its OK button will be truncated. See the attached screenshot: ok-button-screenshot.png. I don't know if this is a duplicate of bug 1417220 or a separate issue.
(Reporter)

Updated

2 months ago
Priority: -- → P2
(Reporter)

Comment 1

2 months ago
Created attachment 8928900 [details]
ok-button-screenshot.png
Looks like it isn't reproducible on Windows...
(Reporter)

Comment 3

2 months ago
The truncated OK button (comment 1 screenshot) is fixed in Nightly 59.0a1 build 2017-11-18, but I can still reproduce the multiple radio button highlights (comment 0 screenshot and STR).
I can reproduce this on macOS. My guess is that the other radio button is not restyled correctly...
FWIW, it seems to me that when I hover the other radio button, the button is then correctly restyled to non-selected state.
So it might be some invalidation issue.
So the related code is: https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/layout/base/GeckoRestyleManager.cpp#412-424

We may need to port some other code to ServoRestyleManager as well... It isn't currently clear what other stuff would affect.
Comment hidden (mozreview-request)
Comment on attachment 8931130 [details]
Bug 1417824 part 1 - Query theme for attribute change on element with appearance.

https://reviewboard.mozilla.org/r/202210/#review207958

Is it worth making a reftest for this?
Attachment #8931130 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee: nobody → xidorn+moz
Comment on attachment 8931815 [details]
Bug 1417824 part 2 - Add reftest for this bug.

https://reviewboard.mozilla.org/r/202938/#review208270

Great, thanks!
Attachment #8931815 - Flags: review?(cam) → review+

Comment 13

2 months ago
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0c7f8a95402
part 1 - Query theme for attribute change on element with appearance. r=heycam
https://hg.mozilla.org/integration/autoland/rev/890ae45c3d15
part 2 - Add reftest for this bug. r=heycam

Comment 14

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d0c7f8a95402
https://hg.mozilla.org/mozilla-central/rev/890ae45c3d15
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
(Reporter)

Comment 15

2 months ago
Verified fixed in Nightly 59.0a1 (2017-11-27).
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
You need to log in before you can comment on or make changes to this bug.