1417841 - The textpath has an offset x, the offset is shown on Chrome and Edge but not Firefox

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[Eric Tsai (no more review request accepted)]

Original from https://webcompat.com/issues/13506

Steps to reproduce:

1. Open the URL
2. Scroll to right, see 109 like this in Firefox
https://webcompat.com/uploads/2017/11/b129097a-5b77-4904-b6fc-37988380b9eb.jpg

<textPath xlink:href="#109" xmlns:xlink="http://www.w3.org/1999/xlink">109</textPath>

in Chrome, it's above the yellow line
https://webcompat.com/uploads/2017/11/23cd7d1f-5a86-420e-b538-38caeb05621a.jpg

Comment 1

[Cameron McCormack (:heycam)]

The issue (as discussed offline) is that we always reset the position of the first <textPath> character to (0, 0), even if there are inheriting x="" / y="" positions from an ancestor text content element.  It looks like other browsers don't do this.  We still need to reset it to (0, 0) when there is no explicit inherited character, otherwise content like

  <text x="100">ABC <textPath href="...">DEF</textPath></text>

would start the DEF text at 100 + advance("ABC ") along the path.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1417841 - Don't reset <textPath> first character coordinate to 0 when an ancestor text content element specifies an explicit position coordinate.

Review commit: https://reviewboard.mozilla.org/r/200268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200268/

Comment 3

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7c6f1af39ab91078e5efca43c24836135bf1e11

Comment 4

[Robert Longson [:longsonr]]

Comment on attachment 8928923 [details]
Bug 1417841 - Don't reset <textPath> first character coordinate to 0 when an ancestor text content element specifies an explicit position coordinate.

https://reviewboard.mozilla.org/r/200268/#review205496

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee0d31af522a
Don't reset <textPath> first character coordinate to 0 when an ancestor text content element specifies an explicit position coordinate. r=longsonr

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ee0d31af522a