1417846 - requireInteraction:true not working with platform-specific desktop notifications (Linux libnotify)

Status: RESOLVED FIXED

(Toolkit :: Alerts Service, defect, P2)

Description

[Rob Wu [:robwu]]

When the "requireInteraction" option is set to true, a persistent notification should be shown. This seems not to happen on Linux with the libnotify backend.

https://bugzilla.mozilla.org/show_bug.cgi?id=862395#c26 wrote some suggestions for implementation, but it seems that nobody ever followed up on that, and requireInteraction is only supported for XUL notifications.

STR:
1. Visit about:config and ensure that dom.webnotifications.requireinteraction.enabled is true.
2. Run the following snippet, e.g. from the devtools in a tab:

Notification.requestPermission().then(function() {
  new Notification('hello', {requireInteraction:true});
});

Expected:
- A notification shows up that sticks around.

Actual:
- The notification disappears after 5 seconds.
  This 5 seconds delay seems to be the default for my system. If I open a terminal and run the following commands, then I can see that the notification disappears at the expected times:
$ notify-send hello         # gone in 5 seconds (default).
$ notify-send -t 1000 hello # gone in 1 second.
$ notify-send -t 9000 hello # gone in 9 seconds.

Comment 1

[Matthew N. [:MattN]]

It seems like this should be fixed (as much as platform support allows; see bug 862395 comment 26) so we aren't shipping a half-baked platform feature.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

I don't think there's any special thing here to be tracked separately, let's track it in bug 1346375.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Oh actually, you say Linux, so why not track it here.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Note for me:

1. Desktop Notifications spec says "resident" is the hint to control this. https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html
2. The relevant code in Gecko is nsAlertsIconListener::ShowAlert. (Why is this in toolkit/ when every other nsIAlertsService implementation is in widget/?)

Comment 5

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Attachment: WIP: Bug 1417846 - Pass "resident" hint when requireInteraction

Comment 6

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Attachment: Bug 1417846 - Part 1: Use using instead of typedef r=stransky

clang-tidy's modernize-use-using rule wants to use using instead.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Attachment: Bug 1417846 - Part 2: Pass timeout=0 when requireInteraction=true r=stransky

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a71193097e1b
Part 1: Use using instead of typedef r=stransky
https://hg.mozilla.org/integration/autoland/rev/bc4d3b22c7eb
Part 2: Pass timeout=0 when requireInteraction=true r=stransky

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a71193097e1b
https://hg.mozilla.org/mozilla-central/rev/bc4d3b22c7eb

Comment 10

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

(MDN says requireInteraction is Windows only)