1417941 - Crash in java.lang.NullPointerException: at org.mozilla.gecko.home.CombinedHistoryPanel.setUpRecyclerView(CombinedHistoryPanel.java)

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Activity Stream, defect, P5)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-da7a4b17-9793-40b5-9a92-92fb60171116.
=============================================================

Seen while looking at 57 crash stats: http://bit.ly/2jxKqz3. This is a new crash only seen in 57 so far.

One comments says "Substratum Theme engine on causing this problem." 

Top 10 frames of crashing thread:

0 libxul.so mozilla::jni::NativeStub<mozilla::java::GeckoAppShell::ReportJavaCrash_t, GeckoAppShellSupport, mozilla::jni::Args<const mozilla::jni::Ref<mozilla::jni::TypedObject<_jthrowable*>, _jthrowable*>&, const mozilla::jni::StringParam&> >::Wrap<GeckoAppShellSupport::ReportJavaCrash> widget/android/nsAppShell.cpp:277
1 base.odex base.odex@0x951d15 
2 dalvik-LinearAlloc_19844_19844 (deleted) dalvik-LinearAlloc_19844_19844 @0x4aaa 
3 dalvik-main space_743_743 (deleted) dalvik-main space_743_743 @0x6a3fe 
4 dalvik-main space_743_743 (deleted) dalvik-main space_743_743 @0x5111be 
5 dalvik-main space_743_743 (deleted) dalvik-main space_743_743 @0x52affe 
6 libart.so libart.so@0xa97c1 
7 dalvik-main space_743_743 (deleted) dalvik-main space_743_743 @0x5111be 
8 dalvik-main space_743_743 (deleted) dalvik-main space_743_743 @0x52affe 
9 base.odex base.odex@0x643be2 

=============================================================

Comment 1

[Marcia Knous [:marcia]]

:jchen any ideas about this one? I have it in the General component right now.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Nevin would you know?

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Looking at the stack trace, it looks like the app crashes when launch.
After HomeConfigLoader is loaded, recyclerView[1] is about to set it's adapter but it's null. 

In theory onViewCreated is called after onCreateView so this won't happen. 
This file hasn't been change since Bug 1401336. So it needs more digging to see what's going on.

Hi Wesly
Please help prioritize

[1] https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java#145

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.support.v7.widget.RecyclerView.setAdapter(android.support.v7.widget.RecyclerView$Adapter)' on a null object reference
	at org.mozilla.gecko.home.CombinedHistoryPanel.setUpRecyclerView(CombinedHistoryPanel.java:175)
	at org.mozilla.gecko.home.CombinedHistoryPanel.onViewCreated(CombinedHistoryPanel.java:146)
	at android.support.v4.app.FragmentManagerImpl.moveToState(Unknown Source)
	at android.support.v4.app.FragmentManagerImpl.moveToState(Unknown Source)
	at android.support.v4.app.BackStackRecord.run(Unknown Source)
	at android.support.v4.app.FragmentManagerImpl.execPendingActions(Unknown Source)
	at android.support.v4.app.FragmentManagerImpl.executePendingTransactions(Unknown Source)
	at android.support.v4.app.FragmentStatePagerAdapter.finishUpdate(Unknown Source)
	at android.support.v4.view.ViewPager.populate(Unknown Source)
	at android.support.v4.view.ViewPager.populate(Unknown Source)
	at android.support.v4.view.ViewPager.setAdapter(Unknown Source)
	at com.booking.rtlviewpager.RtlViewPager.setAdapter(RtlViewPager.java:131)
	at org.mozilla.gecko.home.HomePager.updateUiFromConfigState(HomePager.java:427)
	at org.mozilla.gecko.home.HomePager.access$600(HomePager.java:38)
	at org.mozilla.gecko.home.HomePager$ConfigLoaderCallbacks.onLoadFinished(HomePager.java:516)
	at org.mozilla.gecko.home.HomePager$ConfigLoaderCallbacks.onLoadFinished(HomePager.java:507)
	at android.support.v4.app.LoaderManagerImpl$LoaderInfo.callOnLoadFinished(Unknown Source)
	at android.support.v4.app.LoaderManagerImpl$LoaderInfo.onLoadComplete(Unknown Source)
	at android.support.v4.content.Loader.deliverResult(Unknown Source)
	at org.mozilla.gecko.home.HomeConfigLoader.deliverResult(HomeConfigLoader.java:41)
	at org.mozilla.gecko.home.HomeConfigLoader.deliverResult(HomeConfigLoader.java:13)
	at android.support.v4.content.AsyncTaskLoader.dispatchOnLoadComplete(Unknown Source)
	at android.support.v4.content.AsyncTaskLoader$LoadTask.onPostExecute(Unknown Source)
	at android.support.v4.content.ModernAsyncTask.finish(Unknown Source)
	at android.support.v4.content.ModernAsyncTask.access$400(Unknown Source)
	at android.support.v4.content.ModernAsyncTask$InternalHandler.handleMessage(Unknown Source)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6236)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:891)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:781)

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Added [MobileAS] but I'm not sure if it's related. Also ni myself to look at this.
This only happens in 57 release ( the past 7 days). so strange

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Hi Joe, Wesly
Please help prioritize this.

Comment 6

[Wesly Huang (EPM)]

not seen in the top 50 crashers of 57.0.4, 58.0b14, and 59.0a1 today, lower priority I assume.

Comment 7

[Jan Henning [:JanH]]

Please don't set random flags.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] 5 crashes in 7 days - non-critical.

Comment 9

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.