1417978 - Don't build and ship Layout Debugger for Fennec and GeckoView

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Nick Alexander :nalexander [he/him]]

Discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1417664#c5 suggests that the Layout Debugger shouldn't be built or shipped on Android (i.e., as part of Fennec or as part of GeckoView).  This ticket tracks removing them to simplify assumptions and save APK space.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

To be clear, it's only built at all in debug builds, so it doesn't really impact release users:

https://searchfox.org/mozilla-central/rev/550148ab69b2879bfb82ffa698720ede1fa626f2/layout/moz.build#40-41

So, the main benefit would be a small build time improvement when compiling in debug mode locally.

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1)
> To be clear, it's only built at all in debug builds, so it doesn't really
> impact release users:
> 
> https://searchfox.org/mozilla-central/rev/
> 550148ab69b2879bfb82ffa698720ede1fa626f2/layout/moz.build#40-41
> 
> So, the main benefit would be a small build time improvement when compiling
> in debug mode locally.

Thanks.  This would just be for "GeckoView hygiene", then.  In general, we don't want things to look relevant to GeckoView (and Android in general) when they're not.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

What's the canonical way to test for "building for desktop" in a moz.build file for a core module?

Something like:

```
if CONFIG['OS_TARGET'] in ('WINNT', 'Linux', 'Darwin'):
```

or is there a better way?

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> What's the canonical way to test for "building for desktop" in a moz.build
> file for a core module?
> 
> Something like:
> 
> ```
> if CONFIG['OS_TARGET'] in ('WINNT', 'Linux', 'Darwin'):
> ```
> 
> or is there a better way?

I think we generally test for MOZ_WIDGET_TOOLKIT == 'android': see https://searchfox.org/mozilla-central/source/build/moz.build#22.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1417978 - Stop packaging layout debugger on Android.

The layout debugger UI is only accessible on desktop platforms, so there's no
need to include it for Android builds.

Review commit: https://reviewboard.mozilla.org/r/210256/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210256/

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8939977 [details]
Bug 1417978 - Stop packaging layout debugger on Android.

https://reviewboard.mozilla.org/r/210256/#review215990

lgtm.  Thanks, Ryan!

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f86a1ccde8c6799f17cef36c1735c5dc9011cc65

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d2c81fe9e4c
Stop packaging layout debugger on Android. r=nalexander

Comment 9

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/9d2c81fe9e4c