1417991 - stylo: Worse style system performance than Gecko in https://s.codepen.io/tomhodgins/debug/ggWMpg

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

It looks like we're flushing style twice as often as Gecko, I haven't looked into why yet, but we have a flush from EQCSS.tryWithEval, and then the normal style flush because the stylesheets changed, I think.

 * Gecko profile: https://perfht.ml/2z7mSIe
 * Servo profile: https://perfht.ml/2z8i8lT

Comment 1

[Emilio Cobos Álvarez (:emilio)]

(If someone could confirm that measurements, it'd be nice too!)

Comment 2

[Chris Peterson [:cpeterson]]

Emilio is waiting for mstange's perf.html profile fix to show Stylo frames. Emilio says this bug is not a high priority because a web developer wouldn't design a real website like this.

Comment 3

[Tobi Reif]

"a web developer wouldn't design a real website like this"

Surely Tom Hodgins is a web developer.

We need performance, not insults.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This doesn't look worse than Gecko now I think. If some can confirm that'd be great.

Comment 5

[Mayank Bansal]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)
> This doesn't look worse than Gecko now I think. If some can confirm that'd
> be great.

On latest nightly and clean profile: 

Stylo : https://perfht.ml/2yFfikW
Stylo+Sequential: https://perfht.ml/2yDBXhT

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I think that's pretty ok for now, I don't see anything particularly actionable.