141805 - Find and Replace dialog--escape key doesn't dismiss

Status: VERIFIED WORKSFORME

(SeaMonkey :: Composer, defect)

Description

[Kathleen :Brade]

I always expect that I can dismiss a dialog with the escape key (should trigger
close).  The Find and Replace dialog in Composer doesn't do anything when I
press the escape key.  

On the console, I see a warning:  chrome://editor/content/EdReplace.js line 142:
reference to undefined property gReplaceDialog.findKey

Expectation: I'd like to be able to press the escape key to trigger the close
button.  (I'd also like a close box but that probably belongs in a separate bug?)

Comment 1

[Akkana Peck]

This must be platform-specific; the escape key dismisses the dialog for me on
linux.   Can you dismiss other editor dialogs with escape?  Charley, any
suggestions?

The warning probably isn't related, and should only happen when you search for
something and don't find it.  Indeed, there's no "findKey" in the dialog. 
Perhaps it should change to findField, but I'm not sure what it's doing anyway
(it was copied from other dialog code).  Again I defer to Charley -- any idea
what this line is supposed to be doing?  Can I just remove it?

Strangely, I don't see the warning on linux.  But I do see an assert:
ASSERTION: chrome shouldn't be calling alert(), use the prompt service:
'!isChrome', file nsGlobalWindow.cpp, line 2165
Yet again I have to ask Charley for help -- none of our other editor dialogs
seem to use anything called prompt service.  What should I be doing for the "not
found" subdialog?

Comment 2

[Kathleen :Brade]

very strange; now it works fine!
(maybe it was a focus problem?)

Comment 3

[sujay]

verified.