1418061 - In the new FF57 date input widget with pt locale days of the week appear as segunda, terça, quarta,... These are too long and appear superimposed and scroll bars show up.

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Joao P Matos]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171116103757

Steps to reproduce:

Open a date input widget with FF57 on Linux or Windows with pt locale. For instance
https://math.tecnico.ulisboa.pt/seminars


Actual results:

Days of the week appear in full as "segunda", "terça", "quarta", "quinta", "sexta", "sábado", "domingo". These words are too long for the input wiget and they get superimposed and scroll bars appear.


Expected results:

Taking a hint from paper calendars days of the week should be abbreviated as "Seg", "Ter", "Qua", "Qui", "Sex", Sáb", "Dom".

Comment 1

[Francesco Lodolo [:flod]]

Attachment: S

Screenshot on pt-PT build.

Comment 2

[Francesco Lodolo [:flod]]

I have the feeling this needs to be reported to CLDR
https://www.unicode.org/cldr/charts/32/by_type/date_&_time.gregorian.html#304f66ebdb632c8f

en: sun
pt: dom
pt_PT: domingo

Comment 3

[Francesco Lodolo [:flod]]

@zibi
I'm looking at
http://cldr.unicode.org/index/bug-reports

Do you know more about the process to request changes to CLDR data?

In the meantime, I guess the problem needs also a fix on the layout side (max-width for the label and hide overflow?)

Comment 4

[Mats Palmgren (inactive)]

(In reply to Francesco Lodolo [:flod] (traveling, slow answers, back Nov 22) from comment #3)
> In the meantime, I guess the problem needs also a fix on the layout side
> (max-width for the label and hide overflow?)

Wouldn't that just make errors in localizations harder to detect?

I think the reporter is right, it's a localization error -
these names are expected to be abbreviations.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Mats Palmgren (:mats) from comment #4)
> (In reply to Francesco Lodolo [:flod] (traveling, slow answers, back Nov 22)
> from comment #3)
> > In the meantime, I guess the problem needs also a fix on the layout side
> > (max-width for the label and hide overflow?)
> 
> Wouldn't that just make errors in localizations harder to detect?

It might (you'd likely still see half a character, if we hide the overflow and not truncate the label), but the layout should also not break like this.

> I think the reporter is right, it's a localization error -
> these names are expected to be abbreviations.

In case, that's CLDR error, those translations are not Mozilla's.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

> Do you know more about the process to request changes to CLDR data?

You file a bug in their ticket system and propose a change :)

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

One thing I like to do is also reference such ticket in our Bugzilla's "See Also" if there's a bug for the change you're requesting in CLDR, but that's just my practice to easily remember where to look for updates.

Comment 8

[Francesco Lodolo [:flod]]

We should already be using SHORT
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/datetimepopup.xml#153

But for some reasons we're picking up either wide or abbreviated
https://github.com/unicode-cldr/cldr-dates-modern/blob/master/main/pt-PT/ca-gregorian.json#L105

NI for zibi to figure out if it's a bug in ICU

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

Reported http://bugs.icu-project.org/trac/ticket/13592

Comment 11

[Jonathan Kew [:jfkthame]]

Although hacking in ad-hoc tweaks for specific languages/locales is ugly and non-scalable, I think we should consider applying some kind of fix here so that the calendar looks OK for pt-PT users, while we wait for the ICU/CLDR questions to be resolved upstream. The current behavior of the date picker is really bad for this locale, and it should be trivial for us to work around it, e.g. by just using "pt" in place of "pt-PT" when building the calendar.

Comment 12

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1418061 - Use the generic pt locale in place of pt-PT when constructing date picker, to avoid over-long day names.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2799cfb271ca
Use the generic pt locale in place of pt-PT when constructing date picker, to avoid over-long day names. r=flod

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2799cfb271ca

Comment 15

[Bogdan Maris, Desktop Test Engineering [OOO until Dec 16th]]

Reproduced the initial issue using an old affected version of Firefox (57.0 pt-PT). Verified that months are abbreviated now on 70.0b9 across platforms (macOS 10.13, Ubuntu 18.04 64bit and Windows 10 64bit).