1418078 - Remove nsIDOMHTMLInputElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Continuing post-addon-deprecation XPCOM interface cleanup

Comment 1

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

Review commit: https://reviewboard.mozilla.org/r/238148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238148/

Comment 2

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement.

Review commit: https://reviewboard.mozilla.org/r/238150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238150/

Comment 3

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1418078 - Remove nsIDOMHTMLInputElement.

Review commit: https://reviewboard.mozilla.org/r/238152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238152/

Comment 4

[Adrian Wielgosik [:adrian17]]

FYI, there are a couple nsIDOMHTMLInputElement uses in C-C in suite/ and editor/ that will need to be replaced. Thankfully, that's the last nsIDOMHTML*Element to go.

Comment 5

[Adrian Wielgosik [:adrian17]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa5ced3b313da3171f28aab0be5b84e4c2cfe0ee

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238148/#review244426

::: mobile/android/tests/browser/robocop/testAccessibleCarets.js:51
(Diff revision 1)
>   * or if we have basic content.
>   */
>  function isInputOrTextarea(element) {
>    // ChromeUtils isn't included in robocop tests, so we have to use a different
>    // way to test elements.
> -  return ((element instanceof Ci.nsIDOMHTMLInputElement) ||
> +  return ((ChromeUtils.getClassName(element) === "HTMLInputElement") ||

The comment right above this claims there is no ChromeUtils in this test.  You probably want to do the namespace/tag thing.

::: toolkit/content/tests/chrome/test_menulist.xul:142
(Diff revision 1)
>    is(element.editable, editable, testprefix + " editable");
>  
>    if (editable) {
>      var inputField = element.inputField;
>      is(inputField &&
> -                  inputField instanceof Ci.nsIDOMHTMLInputElement,
> +                  inputField instanceof HTMLInputElement,

Is inputField guaranteed to be from this document?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969434 [details]
Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238150/#review244428

::: toolkit/components/satchel/nsFormFillController.cpp:343
(Diff revision 1)
>    }
>  
> -  mAutofillInputs.Put(node, true);
> -  node->AddMutationObserverUnlessExists(this);
> +  mAutofillInputs.Put(aInput, true);
> +  aInput->AddMutationObserverUnlessExists(this);
>  
> -  nsCOMPtr<nsITextControlElement> txtCtrl = do_QueryInterface(aInput);
> +  nsCOMPtr<nsITextControlElement> txtCtrl = do_QueryInterface((nsIContent*)aInput);

Why do you need this QI or cast?  You can just call aInput->EnablePreview() directly, no?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969435 [details]
Bug 1418078 - Remove nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238152/#review244430

Comment 9

[Frank-Rainer Grahl (:frg)]

Adrian,

thanks for the heads-up. A patch is up for suite in bug 1452486. I just wanted to see what changes are done in mozilla code to verify that it is correct.

Comment 10

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238148/diff/1-2/

Comment 11

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969434 [details]
Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238150/diff/1-2/

Comment 12

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969435 [details]
Bug 1418078 - Remove nsIDOMHTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238152/diff/1-2/

Comment 13

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238148/#review244426

> Is inputField guaranteed to be from this document?

AFAIK it is.

Comment 14

[Adrian Wielgosik [:adrian17]]

Also a Try run with fixed Android tests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1e8886ef7333df48594b22eb5006493c93a3a7a

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238148/#review245592

Comment 16

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b93f9bad03fdcb49fd36718feeec2e0943334715 -d 4da669897520: rebasing 460565:b93f9bad03fd "Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz"
merging accessible/tests/mochitest/events.js
merging browser/extensions/formautofill/FormAutofillContent.jsm
merging toolkit/components/satchel/nsFormAutoComplete.js
rebasing 460566:cc535632b124 "Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement. r=bz"
merging toolkit/components/satchel/nsFormFillController.cpp
warning: conflicts while merging toolkit/components/satchel/nsFormFillController.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 17

[Adrian Wielgosik [:adrian17]]

Rebased at https://reviewboard-hg.mozilla.org/gecko/rev/eb6fb506ecd6 .

Comment 18

[Adrian Wielgosik [:adrian17]]

Rebased at https://reviewboard-hg.mozilla.org/gecko/rev/731ff98f8747

Comment 19

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b93f9bad03fdcb49fd36718feeec2e0943334715 -d e8097237f4be: rebasing 461339:b93f9bad03fd "Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz"
merging accessible/tests/mochitest/events.js
merging browser/extensions/formautofill/FormAutofillContent.jsm
merging dom/browser-element/BrowserElementChildPreload.js
merging mobile/android/components/BrowserCLH.js
merging toolkit/components/passwordmgr/LoginManagerContent.jsm
merging toolkit/components/passwordmgr/nsLoginManager.js
merging toolkit/components/satchel/formSubmitListener.js
merging toolkit/components/satchel/nsFormAutoComplete.js
merging toolkit/modules/sessionstore/FormData.jsm
warning: conflicts while merging accessible/tests/mochitest/events.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 20

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238148/diff/2-3/

Comment 21

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969434 [details]
Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238150/diff/2-3/

Comment 22

[Adrian Wielgosik [:adrian17]]

Comment on attachment 8969435 [details]
Bug 1418078 - Remove nsIDOMHTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238152/diff/2-3/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8ec4fdc18b8
Convert JS users of nsIDOMHTMLInputElement. r=bz
https://hg.mozilla.org/integration/autoland/rev/a7b47097a62e
Convert XPIDL, C++ users of nsIDOMHTMLInputElement. r=bz
https://hg.mozilla.org/integration/autoland/rev/6d8e68a4bf67
Remove nsIDOMHTMLInputElement. r=bz

Comment 24

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e8ec4fdc18b8
https://hg.mozilla.org/mozilla-central/rev/a7b47097a62e
https://hg.mozilla.org/mozilla-central/rev/6d8e68a4bf67