Closed Bug 1418078 Opened 2 years ago Closed Last year

Remove nsIDOMHTMLInputElement

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: qdot, Assigned: adrian17)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Continuing post-addon-deprecation XPCOM interface cleanup
Priority: -- → P3
Assignee: kyle → nobody
Assignee: nobody → ehsan
Assignee: ehsan → nobody
Blocks: 1387169
No longer depends on: 1387169
Depends on: 1439751
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
FYI, there are a couple nsIDOMHTMLInputElement uses in C-C in suite/ and editor/ that will need to be replaced. Thankfully, that's the last nsIDOMHTML*Element to go.
Flags: needinfo?(frgrahl)
Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238148/#review244426

::: mobile/android/tests/browser/robocop/testAccessibleCarets.js:51
(Diff revision 1)
>   * or if we have basic content.
>   */
>  function isInputOrTextarea(element) {
>    // ChromeUtils isn't included in robocop tests, so we have to use a different
>    // way to test elements.
> -  return ((element instanceof Ci.nsIDOMHTMLInputElement) ||
> +  return ((ChromeUtils.getClassName(element) === "HTMLInputElement") ||

The comment right above this claims there is no ChromeUtils in this test.  You probably want to do the namespace/tag thing.

::: toolkit/content/tests/chrome/test_menulist.xul:142
(Diff revision 1)
>    is(element.editable, editable, testprefix + " editable");
>  
>    if (editable) {
>      var inputField = element.inputField;
>      is(inputField &&
> -                  inputField instanceof Ci.nsIDOMHTMLInputElement,
> +                  inputField instanceof HTMLInputElement,

Is inputField guaranteed to be from this document?
Attachment #8969433 - Flags: review?(bzbarsky) → review-
Comment on attachment 8969434 [details]
Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238150/#review244428

::: toolkit/components/satchel/nsFormFillController.cpp:343
(Diff revision 1)
>    }
>  
> -  mAutofillInputs.Put(node, true);
> -  node->AddMutationObserverUnlessExists(this);
> +  mAutofillInputs.Put(aInput, true);
> +  aInput->AddMutationObserverUnlessExists(this);
>  
> -  nsCOMPtr<nsITextControlElement> txtCtrl = do_QueryInterface(aInput);
> +  nsCOMPtr<nsITextControlElement> txtCtrl = do_QueryInterface((nsIContent*)aInput);

Why do you need this QI or cast?  You can just call aInput->EnablePreview() directly, no?
Attachment #8969434 - Flags: review?(bzbarsky) → review+
Comment on attachment 8969435 [details]
Bug 1418078 - Remove nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238152/#review244430
Attachment #8969435 - Flags: review?(bzbarsky) → review+
Adrian,

thanks for the heads-up. A patch is up for suite in bug 1452486. I just wanted to see what changes are done in mozilla code to verify that it is correct.
Flags: needinfo?(frgrahl)
Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238148/#review244426

> Is inputField guaranteed to be from this document?

AFAIK it is.
Comment on attachment 8969433 [details]
Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement.

https://reviewboard.mozilla.org/r/238148/#review245592
Attachment #8969433 - Flags: review?(bzbarsky) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b93f9bad03fdcb49fd36718feeec2e0943334715 -d 4da669897520: rebasing 460565:b93f9bad03fd "Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz"
merging accessible/tests/mochitest/events.js
merging browser/extensions/formautofill/FormAutofillContent.jsm
merging toolkit/components/satchel/nsFormAutoComplete.js
rebasing 460566:cc535632b124 "Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement. r=bz"
merging toolkit/components/satchel/nsFormFillController.cpp
warning: conflicts while merging toolkit/components/satchel/nsFormFillController.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b93f9bad03fdcb49fd36718feeec2e0943334715 -d e8097237f4be: rebasing 461339:b93f9bad03fd "Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz"
merging accessible/tests/mochitest/events.js
merging browser/extensions/formautofill/FormAutofillContent.jsm
merging dom/browser-element/BrowserElementChildPreload.js
merging mobile/android/components/BrowserCLH.js
merging toolkit/components/passwordmgr/LoginManagerContent.jsm
merging toolkit/components/passwordmgr/nsLoginManager.js
merging toolkit/components/satchel/formSubmitListener.js
merging toolkit/components/satchel/nsFormAutoComplete.js
merging toolkit/modules/sessionstore/FormData.jsm
warning: conflicts while merging accessible/tests/mochitest/events.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e8ec4fdc18b8
Convert JS users of nsIDOMHTMLInputElement. r=bz
https://hg.mozilla.org/integration/autoland/rev/a7b47097a62e
Convert XPIDL, C++ users of nsIDOMHTMLInputElement. r=bz
https://hg.mozilla.org/integration/autoland/rev/6d8e68a4bf67
Remove nsIDOMHTMLInputElement. r=bz
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.