Closed
Bug 1418244
Opened 7 years ago
Closed 7 years ago
Missing headers in MSE SourceBufferResource and TrackBuffersManager
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.75 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
This causes build issues in non-unified builds.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → ferjmoreno
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8929391 -
Flags: review?(cpearce)
|
|
Assignee | |
Updated•7 years ago
|
Summary: MSE SourceBufferResource uses AbstractThread without including its header → Missing headers in MSE SourceBufferResource and TrackBuffersManager
|
|
Assignee | |
Comment 2•7 years ago
|
||
TrackBuffersManager uses ErrorResult without including its header as well.
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8929391 -
Attachment is obsolete: true
Attachment #8929391 -
Flags: review?(cpearce)
Attachment #8929535 -
Flags: review?(cpearce)
|
||
Updated•7 years ago
|
Attachment #8929535 -
Flags: review?(cpearce) → review+
|
|
||
Comment 4•7 years ago
|
||
Note: trivial reviews like these on mediasource code if fine for me to do, but anything non-trivial should be reviewed by jya.
|
|
||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29ba2924db2f
Add missing headers to MSE SourceBufferResource and TrackBuffersManager. r=cpearce
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•