1418246 - CSP violation: columnNumber

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P3)

Description

[Chung-Sheng Fu [:cfu]]

Now we don't calculate the column number of CSP violation.  We would like to support it.

Also the web-platform tests should be updated to test the correct column number because they just assert the columnNumber field to be 0 currently.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: csp.patch

This patch exposes the columnNumber value in any CSP violation event but not when the script/style is inline. This is not done because the HTML5 parser doesn't have this information at the moment.

Comment 2

[Andrea Marchesini [:baku]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=32eb7aec1982fac06a41949d07fcec0621353fcd&selectedJob=186001590
It looks green enough. There is a bug in a xpcshell-test but I already fixed it.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8989209 [details] [diff] [review]
csp.patch

Review of attachment 8989209 [details] [diff] [review]:
-----------------------------------------------------------------

Baku, thanks for fixing! r=me

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dea8bb53b30
Return valid columnNumber value in CSP violation events, r=ckerschb

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1dea8bb53b30

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Coverity CID 1437611 suggests that we might have a copy and paste error.

Copy-paste error (COPY_PASTE_ERROR)copy_paste_error: mLineNumber in aViolationEventInit.mLineNumber looks like a copy-paste error.

On this line: https://dxr.mozilla.org/mozilla-central/source/dom/security/nsCSPContext.cpp#1004

Do you confirm that it is a false positive?

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11827 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged