1418314 - "Learn More..." link for Shockwave Flash plugin not working

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[marius.santa]

Attachment: learn more not working.gif

[Affected versions]:
Firefox 59.0a1 (20171116220410)

[Affected platforms]:
Windows 10 64-bit
MacOS Sierra 10.13
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install any addon.
3.Go to "about:addons>Extensions".
4.Click on the "More" button for any extension.
5.Go to "Plugins>Shockwave Flash(More button).
6.Click on "Learn More...".


[Expected Results]:
The user is redirected to "https://support.mozilla.org/en-US/kb/flash-blocklists".

[Actual Results]:
Nothing happens.


[Additional notes]:
I am not sure if steps 2 and 3 are relevant to the bug reproduction but it reproduced 100% after using them.
Gif of issue attached.

Comment 1

[Andy McKay]

Mossop, I think this could have been the changes to toolkit/mozapps/extensions/content/pluginPrefs.xul in bug 1414406. If we don't want to link it up, we could just remove the link. Seems like a useful SUMO page though.

Comment 2

[Dave Townsend [:mossop]]

Argh, apparently I missed this part.

Comment 4

[Andrew Overholt [:overholt]]

Dave, is there anything left to do here?

Comment 5

[Dave Townsend [:mossop]]

(In reply to Andrew Overholt [:overholt] from comment #4)
> Dave, is there anything left to do here?

Yes, it probably needs to be fixed but I haven't had much chance to work on it so far.

Comment 6

[Andrew Overholt [:overholt]]

Ok, my question originated because this bug is marked as a regression in 59 and we track those more closely than regular bugs :)

Comment 7

[Dave Townsend [:mossop]]

Attachment: Bug 1418314: Make the learn more links in plugin details work properly again.

Review commit: https://reviewboard.mozilla.org/r/216982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216982/

Comment 8

[Andrew Swan [:aswan]]

Comment on attachment 8947230 [details]
Bug 1418314: Make the learn more links in plugin details work properly again.

https://reviewboard.mozilla.org/r/216982/#review222840

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/101ece463c39
Make the learn more links in plugin details work properly again. r=aswan

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/101ece463c39

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 8947230 [details]
Bug 1418314: Make the learn more links in plugin details work properly again.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1414406
[User impact if declined]: Learn more links in the details of Flash won't work.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple addition of a href attribute to the existing links
[String changes made/needed]: None

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8947230 [details]
Bug 1418314: Make the learn more links in plugin details work properly again.

Small css fix, fixes a regression, let's take it for 59 beta 7.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e60b08577c89

Comment 14

[Mohammed Adam]

I have Reproduced this bug with Firefox Nightly 60.0a1 (2018-02-06)on Windows 7, (32-bit)

Steps to reproduce:

1)Launched Firefox with New profile
2)Go to "about:addons>Extensions".
3)Click on the "More" button for any extension (for example: I tried Webdeveloper), 
It Shows the Information regarding webdeveloper extension.
4)Then I Gone to "Plugins>Shockwave Flash(More button)" 
5)I just Clicked on Learn More button...

Actual Results: 

After Clicking on "Learn more Button", it is redirected to "https://support.mozilla.org/en-US/kb/flash-blocklists" in a new tab.

Status: Fixed & Verified

FirefoxVersion:60.0a1
Build ID: 20180206100151
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0
OS: Windows_NT 6.1

[bugday-20180207]

Comment 15

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 59.0b5, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 59.0b7, and Fx 60.0a1 (build ID: 20180206220102), on Windows 10 x64, Ubuntu 14.04 LTS x64 and mac OS X 10.11.5.

Cheers!