Webrtc web-platform-tests are disabled because number of concurrent AudioSessionConduits is very limited on windows and linux32

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P2
normal
Rank:
16
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

57 Branch
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(2 attachments)

The limit seems to be 16 on windows, and 24 on linux32. This is preventing web-platform-tests from running properly on these platforms.
Bug 1397793 looks like it will fix this.
Depends on: 1397793
Remember to re-enable WPT tests before closing this, https://reviewboard.mozilla.org/r/200922/#review206178.
Rank: 15
Priority: -- → P2
Rank: 15 → 16
Assignee: nobody → docfaraday
Summary: Number of concurrent AudioSessionConduits is very limited on windows and linux32 → Number of concurrent AudioSessionConduits is very limited on windows and linux32, causing wpt failures
Summary: Number of concurrent AudioSessionConduits is very limited on windows and linux32, causing wpt failures → Webrtc web-platform-tests are disabled because number of concurrent AudioSessionConduits is very limited on windows and linux32
Comment on attachment 8937990 [details]
Bug 1418367 - Part 1: Re-enable webrtc web-platform-tests.

https://reviewboard.mozilla.org/r/208720/#review214462

r=me with fix.

::: testing/web-platform/meta/webrtc/RTCPeerConnection-addTransceiver.html.ini:3
(Diff revision 1)
>    [addTransceiver('audio') should return an audio transceiver]
>      expected: FAIL
>  
>    [addTransceiver('video') should return a video transceiver]
>      expected: FAIL

These pass:

Unexpected Logs
---------------
/webrtc/RTCPeerConnection-addTransceiver.html
  PASS expected FAIL addTransceiver('audio') should return an audio transceiver
  PASS expected FAIL addTransceiver('video') should return a video transceiver
  PASS expected FAIL addTransceiver(track) should have result with sender.track be given track
 1:45.21 LOG: MainThread INFO Closing logging queue
 1:45.22 LOG: MainThread INFO queue closed
Attachment #8937990 - Flags: review?(jib) → review+
Comment on attachment 8937990 [details]
Bug 1418367 - Part 1: Re-enable webrtc web-platform-tests.

https://reviewboard.mozilla.org/r/208720/#review214462

> These pass:
> 
> Unexpected Logs
> ---------------
> /webrtc/RTCPeerConnection-addTransceiver.html
>   PASS expected FAIL addTransceiver('audio') should return an audio transceiver
>   PASS expected FAIL addTransceiver('video') should return a video transceiver
>   PASS expected FAIL addTransceiver(track) should have result with sender.track be given track
>  1:45.21 LOG: MainThread INFO Closing logging queue
>  1:45.22 LOG: MainThread INFO queue closed

I'll be fixing the new wpt problems in Part 2, stay tuned!
Comment on attachment 8938011 [details]
Bug 1418367 - Part 2: Stop expecting failure in a few places in webrtc wpt.

https://reviewboard.mozilla.org/r/208742/#review214682
Attachment #8938011 - Flags: review?(jib) → review+
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/346e06f216b5
Part 1: Re-enable webrtc web-platform-tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/f3759907c55b
Part 2: Stop expecting failure in a few places in webrtc wpt. r=jib
https://hg.mozilla.org/mozilla-central/rev/346e06f216b5
https://hg.mozilla.org/mozilla-central/rev/f3759907c55b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.