1418367 - Webrtc web-platform-tests are disabled because number of concurrent AudioSessionConduits is very limited on windows and linux32

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Byron Campen [:bwc]]

The limit seems to be 16 on windows, and 24 on linux32. This is preventing web-platform-tests from running properly on these platforms.

Comment 1

[Byron Campen [:bwc]]

Bug 1397793 looks like it will fix this.

Comment 2

[Andreas Pehrson [:pehrsons]]

Remember to re-enable WPT tests before closing this, https://reviewboard.mozilla.org/r/200922/#review206178.

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1418367 - Part 1: Re-enable webrtc web-platform-tests.

Review commit: https://reviewboard.mozilla.org/r/208720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208720/

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8937990 [details]
Bug 1418367 - Part 1: Re-enable webrtc web-platform-tests.

https://reviewboard.mozilla.org/r/208720/#review214462

r=me with fix.

::: testing/web-platform/meta/webrtc/RTCPeerConnection-addTransceiver.html.ini:3
(Diff revision 1)
>    [addTransceiver('audio') should return an audio transceiver]
>      expected: FAIL
>  
>    [addTransceiver('video') should return a video transceiver]
>      expected: FAIL

These pass:

Unexpected Logs
---------------
/webrtc/RTCPeerConnection-addTransceiver.html
  PASS expected FAIL addTransceiver('audio') should return an audio transceiver
  PASS expected FAIL addTransceiver('video') should return a video transceiver
  PASS expected FAIL addTransceiver(track) should have result with sender.track be given track
 1:45.21 LOG: MainThread INFO Closing logging queue
 1:45.22 LOG: MainThread INFO queue closed

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8937990 [details]
Bug 1418367 - Part 1: Re-enable webrtc web-platform-tests.

https://reviewboard.mozilla.org/r/208720/#review214462

> These pass:
> 
> Unexpected Logs
> ---------------
> /webrtc/RTCPeerConnection-addTransceiver.html
>   PASS expected FAIL addTransceiver('audio') should return an audio transceiver
>   PASS expected FAIL addTransceiver('video') should return a video transceiver
>   PASS expected FAIL addTransceiver(track) should have result with sender.track be given track
>  1:45.21 LOG: MainThread INFO Closing logging queue
>  1:45.22 LOG: MainThread INFO queue closed

I'll be fixing the new wpt problems in Part 2, stay tuned!

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1418367 - Part 2: Stop expecting failure in a few places in webrtc wpt.

Review commit: https://reviewboard.mozilla.org/r/208742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208742/

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8938011 [details]
Bug 1418367 - Part 2: Stop expecting failure in a few places in webrtc wpt.

https://reviewboard.mozilla.org/r/208742/#review214682

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/346e06f216b5
Part 1: Re-enable webrtc web-platform-tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/f3759907c55b
Part 2: Stop expecting failure in a few places in webrtc wpt. r=jib

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/346e06f216b5
https://hg.mozilla.org/mozilla-central/rev/f3759907c55b