1418398 - gcc on Gentoo defines _FORTIFY_SOURCE as a built-in causing compilation failures when we redefine it

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gabriele Svelto [:gsvelto]]

Gentoo's current stable GCC ebuild patches the sources so that _FORTIFY_BUILD is defined as a built-in if __OPTIMIZE__ is set:

https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/gcc/5.4.0/gentoo/10_all_default-fortify-source.patch?view=markup

This causes build failures because we re-define _FORTIFY_BUILD at configuration time.

Comment 1

[Tom Ritter [:tjr]]

What's correct protocol here? Do we handle this somehow in our config, or should gentoo stop doing this now that it's upstreamed?  (Seems like the latter to me...?)

Comment 2

[Gabriele Svelto [:gsvelto]]

I don't know, I'm tempted to file a Gentoo bug.

Comment 3

[Nathan Froyd [:froydnj]]

Gentoo should stop doing this.  Until such time, perhaps bootstrap can print out instructions to --disable-hardening?

Comment 4

[Tom Ritter [:tjr]]

(In reply to :froydnj (on leave until 2018, ni? or email if necessary) from comment #3)
> Gentoo should stop doing this.  Until such time, perhaps bootstrap can print
> out instructions to --disable-hardening?

That won't work until I figure out how to solve Bug 1418052 :)

Comment 5

[Gabriele Svelto [:gsvelto]]

Quick update: while the fix for this is trivial, version 6.4.0 of GCC has just been marked stable on Gentoo and from the looks of it it doesn't seem to define _FORTIFY_SOURCE anymore. I'll double-check it later today.

Comment 6

[Gabriele Svelto [:gsvelto]]

I was wrong, this applies to version 6.4.0 too, updating the title to reflect that. I've got a quick fix almost ready.

Comment 7

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1418398 - Always un-define _FORTIFY_SOURCE before defining it;

Review commit: https://reviewboard.mozilla.org/r/201288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201288/

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8930118 [details]
Bug 1418398 - Always un-define _FORTIFY_SOURCE before defining it;

https://reviewboard.mozilla.org/r/201288/#review206516

Comment 9

[Gabriele Svelto [:gsvelto]]

Thanks Mike!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c027fdb55dd
Always un-define _FORTIFY_SOURCE before defining it; r=glandium

Comment 11

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/6c027fdb55dd