1418452 - devedition relpro action

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Aki Sasaki (not active)]

In theory this should be super simple, but I'm taking a refactor along with it.

Comment 1

[Aki Sasaki (not active)]

Attachment: devedition.patch

Part 1: add devedition relpro flavors; rename shipping-phases to build/promote/push/ship .

I'm going to attempt part 2: list kinds to *exclude* from previous graphs, rather than explicitly naming previous_graph_kinds. If this doesn't work I'll just leave this patch.

This patch will require a braindump patch as well; incoming.

Comment 2

[Aki Sasaki (not active)]

Attachment: braindump.patch

This should land in braindump when the devedition patch lands on maple.

Comment 3

[Aki Sasaki (not active)]

Attachment: rebuild_kinds.patch

This should simplify our relpro maintenance as we add kinds.

If we think these look good, let's land these two patches on maple and the braindump patch in braindump. I avoided landing right before PTO because I didn't want to bitrot + break everything and then disappear.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8929668 [details] [diff] [review]
devedition.patch

Review of attachment 8929668 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
BTW, when we land this, we should update release-runner3 and the cli tool:

https://dxr.mozilla.org/build-central/rev/af7058b4e00bf49bfa37cbd0f9de813448407911/tools/buildfarm/release/release-runner3.py#154
https://dxr.mozilla.org/build-central/rev/af7058b4e00bf49bfa37cbd0f9de813448407911/tools/buildfarm/release/trigger_action.py#15

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8929675 [details] [diff] [review]
rebuild_kinds.patch

Review of attachment 8929675 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/taskgraph/actions/release_promotion.py
@@ +114,5 @@
>                  'title': 'target task method',
>                  'description': ('Optional: the target task method to use to generate '
>                                  'the new graph.'),
>              },
> +            'rebuild_kinds': {

Hmm, "rebuild" sounds imperative and makes me think that you list the kinds you want to force-rebuild here, but IIRC it does the opposite. I wonder if "reuse_kinds" would be better.

Comment 6

[Aki Sasaki (not active)]

(In reply to Rail Aliiev [:rail] ⌚️ET from comment #5)
> Hmm, "rebuild" sounds imperative and makes me think that you list the kinds
> you want to force-rebuild here, but IIRC it does the opposite. I wonder if
> "reuse_kinds" would be better.

I'm open to a rename, but "reuse_kinds" sounds like we're going to reuse them from the previous graph. rebuild_kinds are the kinds we want to run in the current phase, even if they ran previously.

Comment 7

[Rail Aliiev [:rail]]

Ah, then nevermnind. For some reason I thought that we don't rebuild them.

Comment 8

[Aki Sasaki (not active)]

Attachment: tools_devedition.diff

I think promote_{product} is fine. I'm adding more relpromo flavors to trigger_action. I'm not going to remove publish_fennec until the rename has been uplifted or rides the trains.

Comment 9

[Aki Sasaki (not active)]

https://hg.mozilla.org/build/tools/rev/25a9fb689a38

Comment 10

[Aki Sasaki (not active)]

remote:   https://hg.mozilla.org/projects/maple/rev/71bebbdd517a7c12ff61a7e52e227d53fd9f1ea6
remote:   https://hg.mozilla.org/projects/maple/rev/b4b39cb46d6c196341a6be30484600db6df68fbd

remote:   https://hg.mozilla.org/build/braindump/rev/4add83d0ae2ea8d21c42401b1e4f694b02b789d2
remote:   https://hg.mozilla.org/build/braindump/rev/9ae97cd11027546f25fb2f32cc84b3cb1a96f886
remote:   https://hg.mozilla.org/build/braindump/rev/5188a36232f04e7d4b7abc0e9300e248222253d2
remote:   https://hg.mozilla.org/build/braindump/rev/051c775b88a78ee9068d47e3075fbb09b1e106c5

Comment 11

[Aki Sasaki (not active)]

Sent email.

Comment 12

[Aki Sasaki (not active)]

https://hg.mozilla.org/build/braindump/rev/2aab2ef17f0c