1418453 - Windows ASan blacklist seems to have stopped working

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

When running a Windows ASan build, I crash in the TargetNt functions in exactly the way that bug 1200740 was supposed to fix.

Apparently the blacklist is no longer recognizing the "fun:*TargetNtSetInformationThread@20" syntax. I don't have time to debug or bisect this. Simply changing the end to a wildcard gets around it.

Comment 1

[(Away)]

Attachment: Change asan_blacklist_win.txt syntax to make it work again

I don't have time to investigate why this changed. If this is too much of a hackaround, someone else will have to take it from here.

(Also I'm aware that `Token*` makes `TokenEx*` redundant. I don't think it hurts anything to be explicit.)

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8929578 [details] [diff] [review]
Change asan_blacklist_win.txt syntax to make it work again

I don't really know how to review this, so I'm going to target this review to glandium. froydnj is PTO for the rest of the year, and ting is on parental leave for the rest of the year, so your potential reviewer set here is kind of lowered. If you have a better reviewer in mind, feel free to retarget.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 8929578 [details] [diff] [review]
> Change asan_blacklist_win.txt syntax to make it work again
> 
> I don't really know how to review this, so I'm going to target this review
> to glandium. froydnj is PTO for the rest of the year, and ting is on
> parental leave for the rest of the year, so your potential reviewer set here
> is kind of lowered. If you have a better reviewer in mind, feel free to
> retarget.

In situations like this, I think we sometimes need to just trust the expert, who is often on the hook/the only person able to fix fallout from the fix.  I bet dmajor fits that criteria... but perhaps glandium will prove me wrong with a scathing r- :)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8929578 [details] [diff] [review]
Change asan_blacklist_win.txt syntax to make it work again

Review of attachment 8929578 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/sanitizers/asan_blacklist_win.txt
@@ +5,5 @@
>  # Bug 1200740 - ASan crash due to child process function interceptions
>  # Sandbox executes some of its code before the ASan RTL gets initialized and
>  # maps shadow memory.  As a result, instrumented code tries to access unavailable
>  # shadow memory and faults.
> +fun:*TargetNtSetInformationThread*

shouldn't this work without the final wildcard?

Comment 5

[(Away)]

Comment on attachment 8929578 [details] [diff] [review]
Change asan_blacklist_win.txt syntax to make it work again

(In reply to Mike Hommey [:glandium] from comment #4)
> shouldn't this work without the final wildcard?

I just tried and it doesn't work.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d35ca30f78d
Change asan_blacklist_win.txt syntax to get it working again. r=glandium

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0d35ca30f78d